chore: remove unused pos & card service components (#3737)

* chore(testenv): remove port

* chore(localenv): removed card & pos volumes, ports, seed

* chore(card-service): remove init script

* chore(backend): remove unused card service

* chore(backend): remove card expiry from outgoing payment errors

Author: mkurapov

localenv/admin-auth/dbinit.sql

@@ -6,10 +6,6 @@ CREATE USER cloud_nine_wallet_auth WITH PASSWORD 'cloud_nine_wallet_auth';
 CREATE DATABASE cloud_nine_wallet_auth;
 ALTER DATABASE cloud_nine_wallet_auth OWNER TO cloud_nine_wallet_auth;
 
-CREATE USER cloud_nine_wallet_card WITH PASSWORD 'cloud_nine_wallet_card';
-CREATE DATABASE cloud_nine_wallet_card;
-ALTER DATABASE cloud_nine_wallet_card OWNER TO cloud_nine_wallet_card;
-
 CREATE USER happy_life_bank_backend WITH PASSWORD 'happy_life_bank_backend';
 CREATE DATABASE happy_life_bank_backend;
 ALTER DATABASE happy_life_bank_backend OWNER TO happy_life_bank_backend;
@@ -18,10 +14,6 @@ CREATE USER happy_life_bank_auth WITH PASSWORD 'happy_life_bank_auth';
 CREATE DATABASE happy_life_bank_auth;
 ALTER DATABASE happy_life_bank_auth OWNER TO happy_life_bank_auth;
 
-CREATE USER happy_life_bank_card WITH PASSWORD 'happy_life_bank_card';
-CREATE DATABASE happy_life_bank_card;
-ALTER DATABASE happy_life_bank_card OWNER TO happy_life_bank_card;
-
 CREATE USER happy_life_kratos WITH PASSWORD 'kratos_password';
 CREATE DATABASE happy_life_kratos;
 ALTER DATABASE happy_life_kratos OWNER TO happy_life_kratos;

localenv/cloud-nine-wallet/docker-compose.yml

@@ -10,13 +10,7 @@ services:
     networks:
       - rafiki
     ports:
-      - '3007:3007'
       - '9234:9229'
-    volumes:
-      - type: bind
-        source: ../../packages/card-service/src
-        target: /home/rafiki/packages/card-service/src
-        read_only: true
     environment:
       NODE_ENV: ${NODE_ENV:-development}
       INSTANCE_NAME: CLOUD-NINE

localenv/happy-life-bank/docker-compose.yml

@@ -12,11 +12,6 @@ services:
     ports: 
       - '4008:4008' 
       - '9233:9229'
-    volumes: 
-      - type: bind 
-        source: ../../packages/point-of-sale/src 
-        target: /home/rafiki/packages/point-of-sale/src 
-        read_only: true 
     environment: 
       NODE_ENV: ${NODE_ENV:-development} 
       INSTANCE_NAME: HAPPY-LIFE 

packages/backend/src/card/service.test.ts

@@ -64,7 +64,6 @@ import { createTenantService } from './tenants/service'
 import { AuthServiceClient } from './auth-service-client/client'
 import { createTenantSettingService } from './tenants/settings/service'
 import { createPaymentMethodProviderService } from './payment-method/provider/service'
-import { createCardService, createNoopCardService } from './card/service'
 
 BigInt.prototype.toJSON = function () {
   return this.toString()
@@ -596,16 +595,6 @@ export function initIocContainer(
     })
   })
 
-  container.singleton('cardService', async (deps) => {
-    return config.cardServiceUrl
-      ? createCardService({
-          axios: await deps.use('axios'),
-          logger: await deps.use('logger'),
-          cardServiceUrl: config.cardServiceUrl
-        })
-      : createNoopCardService(await deps.use('logger'))
-  })
-
   return container
 }
 

packages/backend/src/card/service.ts

@@ -18,8 +18,7 @@ export enum OutgoingPaymentError {
   InvalidAmount = 'InvalidAmount',
   NegativeReceiveAmount = 'NegativeReceiveAmount',
   InvalidReceiver = 'InvalidReceiver',
-  OnlyOneGrantAmountAllowed = 'OnlyOneGrantAmountAllowed',
-  InvalidCardExpiry = 'InvalidCardExpiry'
+  OnlyOneGrantAmountAllowed = 'OnlyOneGrantAmountAllowed'
 }
 
 export const quoteErrorToOutgoingPaymentError: Record<
@@ -53,8 +52,7 @@ export const errorToHTTPCode: {
   [OutgoingPaymentError.InvalidAmount]: 400,
   [OutgoingPaymentError.NegativeReceiveAmount]: 400,
   [OutgoingPaymentError.InvalidReceiver]: 400,
-  [OutgoingPaymentError.OnlyOneGrantAmountAllowed]: 500,
-  [OutgoingPaymentError.InvalidCardExpiry]: 400
+  [OutgoingPaymentError.OnlyOneGrantAmountAllowed]: 500
 }
 
 export const errorToCode: {
@@ -71,8 +69,7 @@ export const errorToCode: {
   [OutgoingPaymentError.NegativeReceiveAmount]: GraphQLErrorCode.BadUserInput,
   [OutgoingPaymentError.InvalidReceiver]: GraphQLErrorCode.BadUserInput,
   [OutgoingPaymentError.OnlyOneGrantAmountAllowed]:
-    GraphQLErrorCode.BadUserInput,
-  [OutgoingPaymentError.InvalidCardExpiry]: GraphQLErrorCode.BadUserInput
+    GraphQLErrorCode.BadUserInput
 }
 
 export const errorToMessage: {
@@ -89,8 +86,7 @@ export const errorToMessage: {
   [OutgoingPaymentError.NegativeReceiveAmount]: 'negative receive amount',
   [OutgoingPaymentError.InvalidReceiver]: 'invalid receiver',
   [OutgoingPaymentError.OnlyOneGrantAmountAllowed]:
-    'only one of receiveAmount or debitAmount allowed',
-  [OutgoingPaymentError.InvalidCardExpiry]: 'expired card format MM/YY'
+    'only one of receiveAmount or debitAmount allowed'
 }
 
 export const FundingError = { ...OutgoingPaymentError, ...TransferError }

packages/backend/src/index.ts

@@ -94,8 +94,6 @@ services:
     restart: always
     networks:
       - rafiki-test
-    ports:
-      - '3104:3104'
     environment:
       NODE_ENV: ${NODE_ENV:-development}
       INSTANCE_NAME: CLOUD-NINE