feat(backend): add custom webhook URL for POS (#3628)

* feat(backend): add custom webhook URL for POS

* fix(backend): remove fallback webhook URL for POS

Author: sanducb

packages/backend/src/config/app.ts

@@ -204,7 +204,8 @@ export const Config = {
     false
   ),
   cardServiceUrl: optional(envString, 'CARD_SERVICE_URL'),
-  posServiceUrl: optional(envString, 'POS_SERVICE_URL')
+  posServiceUrl: optional(envString, 'POS_SERVICE_URL'),
+  posWebhookServiceUrl: optional(envString, 'POS_WEBHOOK_SERVICE_URL')
 }
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any

packages/backend/src/open_payments/payment/incoming/service.test.ts

@@ -896,7 +896,7 @@ describe('Incoming Payment Service', (): void => {
           'Creates webhook event for POS service if card payment',
           withConfigOverride(
             () => config,
-            { posServiceUrl: faker.internet.url() },
+            { posWebhookServiceUrl: faker.internet.url() },
             async (): Promise<void> => {
               await expect(
                 IncomingPaymentEvent.query(knex).where({

packages/backend/src/webhook/service.test.ts

@@ -699,7 +699,7 @@ describe('Webhook Service', (): void => {
       'adds webhooks for POS service if event was for a card payment',
       withConfigOverride(
         () => config,
-        { posServiceUrl: faker.internet.url() },
+        { posWebhookServiceUrl: faker.internet.url() },
         async (): Promise<void> => {
           const tenantId = crypto.randomUUID()
           expect(

packages/backend/src/webhook/service.ts

@@ -168,7 +168,7 @@ async function processNextWebhook(
 
       if (webhook.metadata?.sendToPosService) {
         await sendWebhook(deps, webhook, {
-          webhookUrl: `${deps.config.posServiceUrl}/webhook`
+          webhookUrl: deps.config.posWebhookServiceUrl
         })
       } else {
         const settings = await deps_.tenantSettingService.get({
@@ -316,7 +316,7 @@ export function finalizeWebhookRecipients(
 
   if (
     initiationReason === IncomingPaymentInitiationReason.Card &&
-    config.posServiceUrl
+    config.posWebhookServiceUrl
   ) {
     recipients = recipients.concat([
       {
@@ -328,7 +328,7 @@ export function finalizeWebhookRecipients(
     ])
   } else if (
     initiationReason === IncomingPaymentInitiationReason.Card &&
-    !config.posServiceUrl
+    !config.posWebhookServiceUrl
   ) {
     logger?.warn('Could not create webhook recipient for point of sale service')
   }