Skip github.com and githubapp.com images

Author: josh

lib/html/pipeline/camo_filter.rb

@@ -21,10 +21,11 @@ class CamoFilter < Filter
       def call
         doc.search("img").each do |element|
           next if element['src'].nil?
+          next if context[:disable_asset_proxy]
+
           src = element['src'].strip
-          src = src.sub(%r!^http://github.com!, 'https://github.com')
+          next if src.match(%r!^https://(\w+\.)?github(app)?.com!)
 
-          next if context[:disable_asset_proxy]
           element['src'] = asset_proxy_url(src)
         end
         doc

test/html/pipeline/camo_filter_test.rb

@@ -18,12 +18,24 @@ def test_camouflaging_http_image_urls
       CamoFilter.call(orig, @options).to_s
   end
 
-  def test_rewrites_dotcom_image_urls
-    orig = %(<p><img src="http://github.com/img.png"></p>)
+  def test_doesnt_rewrite_dotcom_image_urls
+    orig = %(<p><img src="https://github.com/img.png"></p>)
     assert_equal "<p><img src=\"https://github.com/img.png\"></p>",
       CamoFilter.call(orig, @options).to_s
   end
 
+  def test_doesnt_rewrite_dotcom_subdomain_image_urls
+    orig = %(<p><img src="https://raw.github.com/img.png"></p>)
+    assert_equal "<p><img src=\"https://raw.github.com/img.png\"></p>",
+      CamoFilter.call(orig, @options).to_s
+  end
+
+  def test_doesnt_rewrite_dotcom_app_image_urls
+    orig = %(<p><img src="https://githubapp.com/img.png"></p>)
+    assert_equal "<p><img src=\"https://githubapp.com/img.png\"></p>",
+      CamoFilter.call(orig, @options).to_s
+  end
+
   def test_camouflaging_https_image_urls
     orig = %(<p><img src="https://foo.com/img.png"></p>)
     assert_includes 'img src="' + @asset_proxy_url,