Skip to content

Commit e75961a

Browse files
Update react-modal from 3.13.1 to 3.14.2 to add bugfix-PR 7e732d7 Wrapping getComputedStyle i… (salesforce#2895)
* Update to 3.14.2 to add bugfix-PR 7e732d7 Wrapping getComputedStyle in try catch * Fixing annotation for react-modal package * reverting annotation change * Fixing annotation for react-modal package * reverting annotation change * Updating package.lock file for react-modal version bump * This is a test change to see if this addresses the issue on Travis. Still searching for the root cause Co-authored-by: Stephen James <sjames@salesforce.com>
1 parent 254f5fd commit e75961a

File tree

3 files changed

+26
-22
lines changed

3 files changed

+26
-22
lines changed

components/modal/__tests__/modal.browser-test.jsx

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,16 @@ describe('SLDSModal: ', function () {
2828
appNode = null;
2929
});
3030

31-
afterEach(() => {
32-
ReactDOM.unmountComponentAtNode(container);
33-
document.body.removeChild(container);
34-
container = null;
31+
afterEach((done) => {
32+
// We run into a race condition if we do not have this wait
33+
// with the changes to react-modal, we end up trying to set state
34+
// on an unmounted component
35+
setTimeout(() => {
36+
ReactDOM.unmountComponentAtNode(container);
37+
document.body.removeChild(container);
38+
container = null;
39+
done();
40+
}, 100);
3541
});
3642

3743
const defaultProps = {

package-lock.json

Lines changed: 15 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@
101101
"prop-types": ">=15.7.2",
102102
"react-contenteditable": "^3.3.5",
103103
"react-highlighter": "^0.4.3",
104-
"react-modal": "3.13.1",
104+
"react-modal": "3.14.2",
105105
"react-onclickoutside": "^6.10.0",
106106
"react-required-if": "^1.0.3",
107107
"react-text-truncate": "^0.16.0",

0 commit comments

Comments
 (0)