Skip to content

fix: Actually place channel ids into cache.dm_channels #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

silasary
Copy link
Member

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

After a lot of digging into why I was hitting "You are opening DMs too quickly" errors more than I should have been, I discovered that we never actually stored anything into the cache, and were hitting the API every single lookup.

This fixes that.

Changes

  • Adds a call to place_dm_channel_id

Related Issues

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.47%. Comparing base (7233db2) to head (17b1dc4).
Report is 2 commits behind head on unstable.

Files with missing lines Patch % Lines
interactions/client/smart_cache.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1761      +/-   ##
============================================
+ Coverage     46.41%   46.47%   +0.05%     
============================================
  Files           149      149              
  Lines         16272    16273       +1     
============================================
+ Hits           7553     7563      +10     
+ Misses         8719     8710       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@silasary silasary merged commit 06df222 into unstable Apr 4, 2025
9 of 12 checks passed
@silasary silasary deleted the store-dm-id branch April 4, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants