Skip to content

fix: Invite._process_dict incorrectly passed all data #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

feelixs
Copy link

@feelixs feelixs commented Feb 27, 2025

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Changes

  • For invites of type "target_application" (activity invites), pass data['target_application'] into Application.from_dict() instead of the entire data dict

Related Issues

#1755

Test Scenarios

Steps to Reproduce

  • setup a @listen for a on_raw_gateway_event
  • create a new voice channel (to ensure no invite has been created for it yet) in a guild with the bot
  • give the bot admin perms (i dont know the specific perm that enables bots to view invites, but admin provides all)
  • start a voice chat activity and right click on the voice chat in the sidebar and choose 'invite to join '
  • view the error appear when this patch isn't applied!

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@feelixs feelixs changed the base branch from stable to unstable February 28, 2025 02:20
@silasary silasary merged commit d29f76f into interactions-py:unstable Mar 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants