Skip to content

fix: make _on_raw_message_poll_vote events use correct data #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Lacosst0
Copy link
Contributor

@Lacosst0 Lacosst0 commented Aug 2, 2024

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Original _on_raw_message_poll_vote_add/_on_raw_message_poll_vote_remove are passing data in incorrect order to MessagePollVoteAdd/MessagePollVoteRemove
This pr also makes these events in style of _on_raw_message_delete_bulk

Changes

  • make _on_raw_message_poll_vote_add events use correct data
  • make _on_raw_message_poll_vote_remove events use correct data

Related Issues

Test Scenarios

@listen(MessagePollVoteRemove)
async def on_vote_remove(event):
    print(event.guild_id)
    print(event.channel_id)
    print(event.message_id)
    print(event.user_id)
    print(event.answer_id)

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x
  • I've ensured my code works on Python 3.12.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@AstreaTSS AstreaTSS mentioned this pull request Aug 12, 2024
@AstreaTSS AstreaTSS merged commit ecf7b9e into interactions-py:unstable Aug 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants