fix: fallback to empty list if entitlements is not provided #1715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstreaTSS
changed the title
silasary
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Bizarrely, despite the fact that entitlements are marked as required on the docs, Discord sometimes doesn't provide them, as seen in a help thread. This appears to be an API issue, but this PR still makes entitlements fall back to an empty list if this is the case.
Changes
See description.
Related Issues
Test Scenarios
I'm not 100% sure how this happens
- I personally just added a line to pop the entitlements to recreate the situation.Seems like this issue happens consistently now.Python Compatibility
3.10.x3.11.xChecklist
pre-commitcode linter over all edited files