Skip to content

feat: Add audioop-lts for python 3.13+ #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat: Add audioop-lts for python 3.13+ #1713

merged 1 commit into from
Jul 3, 2024

Conversation

silasary
Copy link
Member

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Our voice support requires audioop, which is depreciated and being removed with python 3.13.

This PR adds audioop-lts as a conditional dependency, readding the now missing module.

Changes

  • audioop-lts; python_version>='3.13'

Related Issues

Fixes #1685

Test Scenarios

I've barely tested it, but it successfully loads, and that's good enough for me

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@silasary silasary merged commit 2a896b7 into unstable Jul 3, 2024
9 of 12 checks passed
@silasary silasary deleted the fix-1685 branch July 3, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants