fix: check for guild for role processors #1542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR fixes role processors from erroring out when the guild cache is limited or made
NullCache
. Previously, the processors assumed the guild would always exist, when this isn't always the case.Worth noting: many more processors use a
fetch_guild
to work around this. That... isn't a good idea here, as if the guild isn't in the cache, we likely don't care about it at all.(Honestly, many processors could benefit from switching from
fetch_guild
toget_guild
, but that would be breaking.)Changes
See the diff.
Related Issues
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files