Skip to content

feat: Provide Guild ID in GuildLeft event #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

silasary
Copy link
Member

@silasary silasary commented Jun 1, 2023

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Occasionally, a bot can recieve a GuildLeave event from an uncached guild. If a user needs to do cleanup, we should provide an ID for them.

Changes

  • Add guild_id field, and pass it in to the event dispatch.

Related Issues

https://discord.com/channels/789032594456576001/1113659088061083699

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.11 ⚠️

Comparison is base (635dee7) 60.24% compared to head (8e39bad) 60.13%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1435      +/-   ##
============================================
- Coverage     60.24%   60.13%   -0.11%     
============================================
  Files           139      139              
  Lines         14702    14705       +3     
============================================
- Hits           8857     8843      -14     
- Misses         5845     5862      +17     
Impacted Files Coverage Δ
interactions/api/events/processors/guild_events.py 70.14% <0.00%> (ø)
interactions/api/events/discord.py 99.64% <100.00%> (+<0.01%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LordOfPolls LordOfPolls merged commit 168311f into unstable Jun 2, 2023
@LordOfPolls LordOfPolls deleted the guild_left_id branch June 2, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants