Skip to content

add sentry arguments #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2023
Merged

add sentry arguments #1433

merged 2 commits into from
Jun 2, 2023

Conversation

Donbur4156
Copy link
Contributor

add optional args for sentry_sdk.init() to further personalize the sentry handler

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Add possibility to pass individual arguments to sentry_sdk.init
Helpful for changing environment to "development" e.g.

Changes

  • add argument "sentry_args" to setup() in sentry.py
  • add "**sentry_args" to sentry_sdk.init() inside setup function

Related Issues

#1432

Test Scenarios

sentry_args = { "environment": "development"}
client.load_extension('interactions.ext.sentry', token=SENTRY_TOKEN, sentry_args=sentry_args)

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

add optional args for sentry_sdk.init() to further personalize the sentry handler
change way of passing args.
instead of dict it takes **kwargs
@LordOfPolls LordOfPolls merged commit 63369e8 into interactions-py:unstable Jun 2, 2023
@Donbur4156 Donbur4156 deleted the add_kwargs_to_sentry_setup branch July 28, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants