Skip to content

docs: fix errors in the bot example and add intent #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 31, 2023
Merged

docs: fix errors in the bot example and add intent #1416

merged 8 commits into from
May 31, 2023

Conversation

rdni
Copy link
Contributor

@rdni rdni commented May 21, 2023

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Changed the example bot to make it function correctly as well as have up to date information on the docs

Changes

  • Changed the docs link to be up to date
  • Added the message content intent.
  • Changed the parameter for the message listen from "interactions.Message" to "interactions.api.events.MessageCreate".

Related Issues

Test Scenarios

No tests are required as it is not changing the library it self

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

rdni and others added 2 commits May 21, 2023 19:25
@rdni
Fix errors in the bot example and add intent
cac1b58 
Added the message content intent, so that the event listener works correctly, and changed the parameter for the message listen from "interactions.Message" to "interactions.api.events.MessageCreate" to fix the event.

Signed-off-by: redninja9854 <100790587+redninja9854@users.noreply.github.com>
@pre-commit-ci
ci: correct from checks.
e91a8ec
AstreaTSS
AstreaTSS reviewed May 22, 2023
View reviewed changes
Copy link
Member

@AstreaTSS AstreaTSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a good start - just need a couple of wording adjustments (and one code change).

AstreaTSS
AstreaTSS reviewed May 22, 2023
View reviewed changes
@AstreaTSS AstreaTSS changed the title Fix errors in the bot example and add intent docs: fix errors in the bot example and add intent May 22, 2023
rdni and others added 2 commits May 22, 2023 07:54
@rdni
Reword comments
064fed3 
Reduce confusion when reading the comments

Signed-off-by: redninja9854 <100790587+redninja9854@users.noreply.github.com>
@pre-commit-ci
ci: correct from checks.
598880f
silasary
silasary reviewed May 24, 2023
View reviewed changes
rdni and others added 3 commits May 24, 2023 17:05
@rdni
Change message listener comments
9e3d48e 
Changed the comment explaining what message create was to make it clearer.

Signed-off-by: redninja9854 <100790587+redninja9854@users.noreply.github.com>
@pre-commit-ci
ci: correct from checks.
830a61b
@rdni
Merge branch 'unstable' into unstable
842b4e0
@LordOfPolls LordOfPolls merged commit 00bfe2b into interactions-py:unstable May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstreaTSS AstreaTSS AstreaTSS left review comments

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rdni @silasary @AstreaTSS @LordOfPolls