Skip to content

Commit ceca2c9

Browse files
author
Tomas Winkler
committed
safestringlib: unittests: add test counter to strisdigit_s and strismixed_s.c
Add test counters to strisdigit_s strismixed_s.c Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
1 parent e8eed19 commit ceca2c9

File tree

2 files changed

+76
-7
lines changed

2 files changed

+76
-7
lines changed

unittests/test_strisdigit_s.c

Lines changed: 51 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
/* SPDX-License-Identifier: MIT */
22
/*
3-
* Copyright (c) 2014 by Intel Corp
3+
* Copyright (c) 2014-2022 Intel Corp
4+
*/
45
/*------------------------------------------------------------------
56
* test_strisdigit_s
67
*
@@ -13,84 +14,113 @@
1314
#define LEN ( 128 )
1415

1516

16-
int test_strisdigit_s()
17+
int test_strisdigit_s(void)
1718
{
1819
bool rc;
1920

20-
uint32_t len;
21-
char str[LEN];
21+
rsize_t len;
22+
char str[LEN];
23+
unsigned int testno = 0;
24+
unsigned int err = 0;
25+
26+
27+
printf("\nTesting strisdigit_s:\n");
2228

2329
/*--------------------------------------------------*/
2430

31+
/* 1: Test for first parameter, char string, being sent in as NULL */
32+
printf("Test #%d:\n", ++testno);
33+
2534
len = 5;
2635
rc = strisdigit_s(NULL, len);
2736
if (rc != false) {
2837
printf("%s %u Error rc=%u \n",
2938
__FUNCTION__, __LINE__, rc );
39+
err++;
3040
}
3141

3242
/*--------------------------------------------------*/
3343

44+
printf("Test #%d:\n", ++testno);
45+
3446
len = 0;
3547
rc = strisdigit_s("1234", len);
3648
if (rc != false) {
3749
printf("%s %u Error rc=%u \n",
3850
__FUNCTION__, __LINE__, rc );
51+
err++;
3952
}
4053

4154
/*--------------------------------------------------*/
4255

56+
printf("Test #%d:\n", ++testno);
57+
4358
len = 99999;
4459
rc = strisdigit_s("1234", len);
4560
if (rc != false) {
4661
printf("%s %u Error rc=%u \n",
4762
__FUNCTION__, __LINE__, rc );
63+
err++;
4864
}
4965

5066
/*--------------------------------------------------*/
5167

68+
printf("Test #%d:\n", ++testno);
69+
5270
len = 9;
5371
rc = strisdigit_s("", len);
5472
if (rc != false) {
5573
printf("%s %u Error rc=%u \n",
5674
__FUNCTION__, __LINE__, rc );
75+
err++;
5776
}
5877

5978
/*--------------------------------------------------*/
6079

80+
printf("Test #%d:\n", ++testno);
81+
6182
strcpy(str, "123456789");
6283
len = 4;
6384

6485
rc = strisdigit_s(str, len);
6586
if (rc != true) {
6687
printf("%s %u Error rc=%u \n",
6788
__FUNCTION__, __LINE__, rc );
89+
err++;
6890
}
6991

7092
/*--------------------------------------------------*/
7193

94+
printf("Test #%d:\n", ++testno);
95+
7296
strcpy(str, "1");
7397
len = strlen(str);
7498

7599
rc = strisdigit_s(str, len);
76100
if (rc != true) {
77101
printf("%s %u Error rc=%u \n",
78102
__FUNCTION__, __LINE__, rc );
103+
err++;
79104
}
80105

81106
/*--------------------------------------------------*/
82107

108+
printf("Test #%d:\n", ++testno);
109+
83110
strcpy(str, "12");
84111
len = strlen(str);
85112

86113
rc = strisdigit_s(str, len);
87114
if (rc != true) {
88115
printf("%s %u Error rc=%u \n",
89116
__FUNCTION__, __LINE__, rc );
117+
err++;
90118
}
91119

92120
/*--------------------------------------------------*/
93121

122+
printf("Test #%d:\n", ++testno);
123+
94124
strcpy(str, "1abcd");
95125
len = strlen(str);
96126

@@ -102,16 +132,32 @@ int test_strisdigit_s()
102132

103133
/*--------------------------------------------------*/
104134

135+
printf("Test #%d:\n", ++testno);
136+
105137
strcpy(str, "abcd");
106138
len = strlen(str);
107139

108140
rc = strisdigit_s(str, len);
109141
if (rc != false) {
110142
printf("%s %u Error rc=%u \n",
111143
__FUNCTION__, __LINE__, rc );
144+
err++;
112145
}
113146

114147
/*--------------------------------------------------*/
115148

116-
return (0);
149+
/* Test for non terminated string */
150+
printf("Test #%d:\n", ++testno);
151+
152+
memset(str, '6', LEN);
153+
len = LEN - 3;
154+
155+
rc = strisdigit_s(str, len);
156+
if (rc != true) {
157+
printf("%s %u Error rc=%u \n",
158+
__FUNCTION__, __LINE__, rc );
159+
err++;
160+
}
161+
162+
return (err == 0) ? 0 : 1;
117163
}

unittests/test_strismixed_s.c

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,21 @@
1414
#define LEN ( 128 )
1515

1616

17-
int test_strismixed_s()
17+
int test_strismixed_s(void)
1818
{
1919
bool rc;
2020
rsize_t len;
21-
char str[LEN];
21+
char str[LEN];
22+
unsigned int testno = 0;
23+
24+
25+
printf("\nTesting strisdigit_s:\n");
2226

2327
/*--------------------------------------------------*/
2428

29+
/* 1: Test for first parameter, char string, being sent in as NULL */
30+
printf("Test #%d:\n", ++testno);
31+
2532
len = 5;
2633
rc = strismixedcase_s(NULL, len);
2734
if (rc != false) {
@@ -31,6 +38,8 @@ int test_strismixed_s()
3138

3239
/*--------------------------------------------------*/
3340

41+
printf("Test #%d:\n", ++testno);
42+
3443
len = 0;
3544
rc = strismixedcase_s("test", len);
3645
if (rc != false) {
@@ -40,6 +49,8 @@ int test_strismixed_s()
4049

4150
/*--------------------------------------------------*/
4251

52+
printf("Test #%d:\n", ++testno);
53+
4354
len = RSIZE_MAX_STR+1;
4455
rc = strismixedcase_s("test", len);
4556
if (rc != false) {
@@ -49,6 +60,8 @@ int test_strismixed_s()
4960

5061
/*--------------------------------------------------*/
5162

63+
printf("Test #%d:\n", ++testno);
64+
5265
len = 9;
5366
rc = strismixedcase_s("", len);
5467
if (rc != false) {
@@ -58,6 +71,8 @@ int test_strismixed_s()
5871

5972
/*--------------------------------------------------*/
6073

74+
printf("Test #%d:\n", ++testno);
75+
6176
strcpy(str, "AaBbCcDdEeFf");
6277
len = 5;
6378

@@ -69,6 +84,8 @@ int test_strismixed_s()
6984

7085
/*--------------------------------------------------*/
7186

87+
printf("Test #%d:\n", ++testno);
88+
7289
strcpy(str, "N");
7390
len = strlen(str);
7491

@@ -80,6 +97,8 @@ int test_strismixed_s()
8097

8198
/*--------------------------------------------------*/
8299

100+
printf("Test #%d:\n", ++testno);
101+
83102
strcpy(str, "NowISTHETimE");
84103
len = strlen(str);
85104

@@ -91,6 +110,8 @@ int test_strismixed_s()
91110

92111
/*--------------------------------------------------*/
93112

113+
printf("Test #%d:\n", ++testno);
114+
94115
strcpy(str, "qq21ego");
95116
len = strlen(str);
96117

@@ -102,6 +123,8 @@ int test_strismixed_s()
102123

103124
/*--------------------------------------------------*/
104125

126+
printf("Test #%d:\n", ++testno);
127+
105128
strcpy(str, "1234");
106129
len = strlen(str);
107130

0 commit comments

Comments
 (0)