From bd802513bb5f1c24b0a9e610ac75187dfa41ebc8 Mon Sep 17 00:00:00 2001 From: "Danilczuk, Lukasz" Date: Tue, 28 Jun 2022 10:03:38 +0100 Subject: [PATCH] Power optimisation library - C-States functionality --- pkg/power/pool.go | 3 --- pkg/power/power.go | 5 ++++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/power/pool.go b/pkg/power/pool.go index ff3dffd..7418cfd 100644 --- a/pkg/power/pool.go +++ b/pkg/power/pool.go @@ -92,9 +92,6 @@ func (pool *poolImpl) removeCoreByID(coreId int) (Core, error) { if index < 0 { return nil, errors.Errorf("core id %d not found in pool %s", coreId, pool.Name) } - if coreObj.getReserved() { - return coreObj, errors.Errorf("Core %d is system reserved and cannot be moved", coreId) - } return coreObj, pool.doRemoveCore(index) } diff --git a/pkg/power/power.go b/pkg/power/power.go index 7af8190..4fe9f83 100644 --- a/pkg/power/power.go +++ b/pkg/power/power.go @@ -27,7 +27,6 @@ var supportedFeatureErrors = map[int]error{ // returns node object with empty list of exclusive pools, and a default pool containing all cpus // by default all cpus are set to system reserved func CreateInstance(nodeName string) (Node, error) { - // TODO this will need to change in manager var allErrors *multierror.Error checks := preChecks() // if more or equal errors than supported features has occurred @@ -113,3 +112,7 @@ func IsFeatureSupported(features ...int) bool { } return true } + +func FeatureSupportError(feature int) error { + return supportedFeatureErrors[feature] +}