Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a NetworkPolicy for the PCM (Performance Counter Monitor) service to support Kubernetes environments with default deny network policies. The changes make the network configuration more explicit and maintainable by using named ports.
- Updates health check probes to reference ports by name instead of number
- Adds a NetworkPolicy resource allowing ingress traffic to the metrics endpoint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jcpunk
force-pushed
the
port-names-and-policies
branch
from
1a6c22e to
326c675
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Pat Riehecky <riehecky@fnal.gov>
jcpunk
force-pushed
the
port-names-and-policies
branch
from
326c675 to
e9fb92f
Compare
Contributor
|
could you provide a proof that the latest change is working? |
Contributor
Author
|
It has been running at my site for a few weeks now without issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets a networkPolicy for pcm. It is useful for environments where a default deny network policy is created. It further documents the behavior by using named ports within the pod.
This policy is easy to modify for folks who want to limit access to only the prometheus server.