Skip to content

Add support for session option ep.stop_context_sharing #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025

Conversation

javier-intel
Copy link

Description

This PR does some cleanup on session options and also adds support for ep.stop_context_sharing

Motivation and Context

Add support for ep.stop_context_sharing to cleanup shared context data.

@javier-intel javier-intel force-pushed the jemartin/stop_context_sharing branch from a06caa8 to 10faab9 Compare April 14, 2025 07:58
Copy link

@sfatimar sfatimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some CPP Lint Issues

@sfatimar
Copy link

Please update branch as well.

@javier-intel javier-intel force-pushed the jemartin/stop_context_sharing branch from 10faab9 to c1b6a5a Compare April 17, 2025 16:32
@javier-intel
Copy link
Author

Done updating the branch and making Lint fixes. I had used Lintrunner before creating the PR and I still don't see the issues highlighted. Who can I talk to about the job to make sure I can reproduce it locally?

@ankitm3k
Copy link

kindly update the base branch.

Copy link

@ankitm3k ankitm3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes lgtm

@javier-intel
Copy link
Author

kindly update the base branch.

Hey @ankitm3k I see the PR branch is in sync with ovep-develop, am I missing something?

@javier-intel javier-intel force-pushed the jemartin/stop_context_sharing branch from e8c6aeb to 604f538 Compare April 22, 2025 11:32
@javier-intel javier-intel force-pushed the jemartin/stop_context_sharing branch from 604f538 to 3451a69 Compare April 22, 2025 16:01
@ankitm3k ankitm3k merged commit 269f6fe into ovep-develop Apr 23, 2025
6 of 8 checks passed
ankitm3k added a commit that referenced this pull request Apr 23, 2025
ankitm3k added a commit that referenced this pull request Apr 24, 2025
intbf pushed a commit to intbf/onnxruntime that referenced this pull request Apr 25, 2025
* Add function to query external initializer file name

* Decouple external weight processing from shared context and add support for stop context sharing

Signed-off-by: bfilipek <bartlomiej.filipek@intel.com>
intbf pushed a commit to intbf/onnxruntime that referenced this pull request Apr 25, 2025
…#655)" (intel#674)

This reverts commit 269f6fe.

Signed-off-by: bfilipek <bartlomiej.filipek@intel.com>
ankitm3k pushed a commit that referenced this pull request Jul 2, 2025
* Add function to query external initializer file name

* Decouple external weight processing from shared context and add support for stop context sharing
ankitm3k added a commit that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants