common: resolve_unique: Fix uninitialised return of pointer item

ColinIanKing · ColinIanKing · commit 3095e829f785 · 2024-08-06T15:58:21.000+01:00
In the case where resolve_unique does not resolve a unique symbol
the uninitialzed pointer item is returned which is problematic because
the caller performs a NULL check on this. Fix this be initializing
item to NULL at the start.

Signed-off-by: Colin Ian King &lt;colin.i.king@gmail.com&gt;
diff --git a/common/os/sym.c b/common/os/sym.c
@@ -842,7 +842,7 @@ sym_resolve(sym_t *sym, uint64_t addr, sym_item_t **item_arr,
 static sym_item_t *
 resolve_unique(sym_t *sym, uint64_t addr, sym_item_t **arr, uint64_t *base_addr)
 {
-	sym_item_t *item_arr, *item;
+	sym_item_t *item_arr, *item = NULL;
 	int num, i;
 
 	if (sym_resolve(sym, addr, &item_arr, &num, base_addr) != 0) {

Original file line number	Diff line number	Diff line change
`@@ -842,7 +842,7 @@ sym_resolve(sym_t sym, uint64_t addr, sym_item_t *item_arr,`
`842`	`842`	`static sym_item_t *`
`843`	`843`	`resolve_unique(sym_t sym, uint64_t addr, sym_item_t arr, uint64_t base_addr)`
`844`	`844`	`{`
`845`		`- sym_item_t item_arr, item;`
	`845`	`+ sym_item_t item_arr, item = NULL;`
`846`	`846`	`int num, i;`
`847`	`847`
`848`	`848`	`if (sym_resolve(sym, addr, &item_arr, &num, base_addr) != 0) {`