Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver installation should use libva.pc driverdir variable #2

Closed
uartie opened this issue Dec 1, 2017 · 1 comment
Closed

Driver installation should use libva.pc driverdir variable #2

uartie opened this issue Dec 1, 2017 · 1 comment

Comments

@uartie
Copy link
Contributor

uartie commented Dec 1, 2017

LibVA provides a pkgconfig (libva.pc) file that defines a driverdir variable. This variable specifies the default path that libva will search for drivers. This variable can be obtained with pkg-config libva --variable driverdir. The cmake configuration should use this driverdir as the default installation location for the driver (but still allow it to be overridden by developer... e.g. -DLIBVA_DRIVERS_PATH=). Obviously, users can still override libva driver search path with environment var at runtime.

uartie added a commit to uartie/media-driver that referenced this issue Dec 1, 2017
1. If -DLIBVA_DRIVERS_PATH not defined and
   -DLIBVA_INSTALL_PATH defined, then set LIBVA_DRIVERS_PATH to
   a default value.

2. If -DLIBVA_DRIVERS_PATH not defined and
   -DLIBVA_INSTALL_PATH not defined, then set LIBVA_DRIVERS_PATH to
   libva.pc (pkgconfig) driverdir value if LIBVA_FOUND, otherwise
   set to a default value.

3. If -DLIBVA_DRIVERS_PATH defined, then use it.

Fixes intel#2

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
@oliver-sang
Copy link
Contributor

thanks for reporting this issue and thanks for the PR. I ran into some problem while trying your PR which I added comments in PR. Could you help? Thanks

uartie added a commit to uartie/media-driver that referenced this issue Dec 4, 2017
1. If -DLIBVA_DRIVERS_PATH not defined and
   -DLIBVA_INSTALL_PATH defined, then set LIBVA_DRIVERS_PATH to
   a default value.

2. If -DLIBVA_DRIVERS_PATH not defined and
   -DLIBVA_INSTALL_PATH not defined, then set LIBVA_DRIVERS_PATH to
   libva.pc (pkgconfig) driverdir value if LIBVA_FOUND, otherwise
   set to a default value.

3. If -DLIBVA_DRIVERS_PATH defined, then use it.

Fixes intel#2

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit to uartie/media-driver that referenced this issue Dec 4, 2017
1. If -DLIBVA_DRIVERS_PATH not defined and
   -DLIBVA_INSTALL_PATH defined, then set LIBVA_DRIVERS_PATH to
   a default value.

2. If -DLIBVA_DRIVERS_PATH not defined and
   -DLIBVA_INSTALL_PATH not defined, then set LIBVA_DRIVERS_PATH to
   libva.pc (pkgconfig) driverdir value if LIBVA_FOUND, otherwise
   set to a default value.

3. If -DLIBVA_DRIVERS_PATH defined, then use it.

Fixes intel#2

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
uartie added a commit to uartie/media-driver that referenced this issue Dec 7, 2017
1. If -DLIBVA_DRIVERS_PATH not defined and
   -DLIBVA_INSTALL_PATH defined, then set LIBVA_DRIVERS_PATH to
   a default value.

2. If -DLIBVA_DRIVERS_PATH not defined and
   -DLIBVA_INSTALL_PATH not defined, then set LIBVA_DRIVERS_PATH to
   libva.pc (pkgconfig) driverdir value if LIBVA_FOUND, otherwise
   set to a default value.

3. If -DLIBVA_DRIVERS_PATH defined, then use it.

Fixes intel#2

Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
intel-mediadev pushed a commit that referenced this issue Jun 20, 2019
Fix linux perf fail

Change-Id: Id8391035b6a903f035204043d031893217755860
intel-mediadev pushed a commit that referenced this issue Jul 11, 2019
Fix MAV issues group #2 on ICL for gfx-driver-user-comp_media-17172

Change-Id: Icd9c55aac5cfa1a67c85aa83f0b5a9b1ba7c6f6d
intel-mediadev pushed a commit that referenced this issue Oct 31, 2019
AVC/VP9/HEVC: Allocate internal histogram resource to get histogram and use huc copy to app allocated resource
Change-Id: I1b93a5a93ce871f54dedc4cd2b4bb1564bdaa6fb
intel-mediadev pushed a commit that referenced this issue Nov 26, 2019
Change-Id: Ib4713948ed1ca0f6c9cb465cee9fb6e995fe5cc8
intel-mediadev pushed a commit that referenced this issue Feb 11, 2020
SVN backmerge - Encoder codechal gen11 changes #2

Change-Id: Ib6b3873a4519482380bfa61efd316b409528c993
intel-mediadev pushed a commit that referenced this issue May 29, 2020
Implement lmem policy

Change-Id: I5a51f4c1cdf9f8fffac902f4c278bd73d2e09270
intel-mediadev pushed a commit that referenced this issue Aug 26, 2020
[Encode] Release unused pointer in GEN12 HEVC codec
Release unused pointer in GEN12 HEVC codec to get avoid of memory leak #2

Change-Id: I9575873f159c333adb40f23b8cecaa85c3d41b77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants