Skip to content

[SYCL][CUDA] Add missing device scope to atomic fence #9824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 13, 2023
Merged

[SYCL][CUDA] Add missing device scope to atomic fence #9824

merged 2 commits into from
Jun 13, 2023

Conversation

npmiller
Copy link
Contributor

This patch maps Device scope fence to the right NVVM built-in. It would previously incorrectly use the CTA (threadblock) variant.

@npmiller
[SYCL][CUDA] Add missing device scope to atomic fence
fab368b 
This patch maps `Device` scope fence to the right NVVM built-in. It
would previously incorrectly use the CTA (threadblock) variant.
@npmiller npmiller requested a review from a team as a code owner June 12, 2023 14:39
@npmiller npmiller requested a review from jchlanda June 12, 2023 14:39
@npmiller npmiller temporarily deployed to aws June 12, 2023 16:12 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to aws June 12, 2023 18:00 — with GitHub Actions Inactive
@npmiller
Copy link
Contributor Author

The tests failures are only Basic/handler/handler_mem_op.cpp, and seem to be happening in other PRs as well, not quite sure what's going on with it but I don't believe it's related to this patch.

@steffenlarsen
Copy link
Contributor

The tests failures are only Basic/handler/handler_mem_op.cpp, and seem to be happening in other PRs as well, not quite sure what's going on with it but I don't believe it's related to this patch.

The failure should have been addressed by #9829. I will retrigger the CI.

steffenlarsen
steffenlarsen approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@npmiller npmiller temporarily deployed to aws June 13, 2023 10:55 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to aws June 13, 2023 11:34 — with GitHub Actions Inactive
@steffenlarsen
Copy link
Contributor

@npmiller - It looks like you might need to push a merge commit for it to correctly rebase your changes.

@npmiller npmiller temporarily deployed to aws June 13, 2023 12:57 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to aws June 13, 2023 14:12 — with GitHub Actions Inactive
@npmiller
Copy link
Contributor Author

@steffenlarsen the merge worked, looks like all the issues are resolved now!

@steffenlarsen steffenlarsen merged commit 93eb9ff into intel:sycl Jun 13, 2023
fineg74 pushed a commit to fineg74/llvm that referenced this pull request Jun 15, 2023
@npmiller @fineg74
[SYCL][CUDA] Add missing device scope to atomic fence (intel#9824)
b246ead 
This patch maps `Device` scope fence to the right NVVM built-in. It
would previously incorrectly use the CTA (threadblock) variant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchlanda jchlanda jchlanda approved these changes

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@0x12CC 0x12CC 0x12CC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@npmiller @steffenlarsen @jchlanda @0x12CC