Skip to content

[SYCL] Modifies accessor::ConcreteASPtrType to be const for readonly accessor #9651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2023
Merged

[SYCL] Modifies accessor::ConcreteASPtrType to be const for readonly accessor #9651

merged 3 commits into from
May 31, 2023

Conversation

mmoadeli
Copy link
Contributor

  • Modifies accessor::ConcreteASPtrType to be const for readonly accessor to fix failing case where copying accessor::MData does not compile when src type is const and dest is non-const.
  • Add test

mmoadeli added 3 commits May 30, 2023 17:40
@mmoadeli
Modifies accessor::ConcreteASPtrType to be const for readonly acces…
8855e06 
…sor to fix failing case where copying accessor<const T>::MData does not compile when src type is `const` and dest is non-const.
@mmoadeli
Minor updates in accesssor/accessor.cpp tests
a940738
@mmoadeli
Add comment for implict conversion test case.
ef6e335
@mmoadeli mmoadeli requested a review from a team as a code owner May 30, 2023 16:55
@mmoadeli mmoadeli requested a review from bso-intel May 30, 2023 16:55
@mmoadeli mmoadeli changed the title Modifies accessor::ConcreteASPtrType to be const for readonly accessor [SYCL] Modifies accessor::ConcreteASPtrType to be const for readonly accessor May 30, 2023
@mmoadeli mmoadeli requested a review from steffenlarsen May 30, 2023 16:59
steffenlarsen
steffenlarsen approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmoadeli mmoadeli temporarily deployed to aws May 30, 2023 18:38 — with GitHub Actions Inactive
@mmoadeli mmoadeli temporarily deployed to aws May 30, 2023 20:52 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen merged commit fd45980 into intel:sycl May 31, 2023
whitneywhtsang added a commit to sys-ce-bb/llvm that referenced this pull request May 31, 2023
@whitneywhtsang
Revert "[SYCL] Modifies accessor::ConcreteASPtrType to be const for…
3597fbc 
… `readonly` accessor (intel#9651)"

This reverts commit fd45980.
@mmoadeli mmoadeli deleted the fix-const-copy-acc2 branch July 7, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmoadeli @steffenlarsen