[SYCL][InvokeSimd][E2E] Fix scale tests on hardware that doesn't support fp64 #9552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do a check with `dev.has(aspect::fp64)`, but that's a runtime check. With InvokeSimd, we need to compile with `-fno-sycl-device-code-split-esimd` which disables any module splitting. Usually modules are split into images based on optional device features, such as fp64, but because of the above option we only end up with a single device image that contains both fp64 and non-fp64 code because of the runtime check. Since there can only be one image, we can't use fp64 at all on non-fp64 hardware, so a runtime check won't work. Split the test into a non-fp64 and fp64-only version. The above is what we do for other tests that test double conditionally on non-fp64 hardware, such as invoke_simd_conv_double.cpp Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
sarnex
changed the title
v-klochkov
approved these changes
May 23, 2023
Good idea, thanks |
sarnex
added a commit
to sarnex/llvm
that referenced
this pull request
Jun 13, 2023
… hardware that doesn't support fp64 (intel#9552)" After 8e19a94, the splitting does the right thing with `invoke_simd`. This reverts commit 8e19a94.
v-klochkov
pushed a commit
that referenced
this pull request
Jun 13, 2023
fineg74
pushed a commit
to fineg74/llvm
that referenced
this pull request
Jun 15, 2023
…upport fp64 (intel#9552)" (intel#9826) After 2910add, the splitting does the right thing with `invoke_simd`, and we can use this test to lock down the functionality which previously didn't work. This reverts commit 8e19a94.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do a check with
dev.has(aspect::fp64), but that's a runtime check.With InvokeSimd, we need to compile with
-fno-sycl-device-code-split-esimdwhich disables any module splitting.Usually modules are split into images based on optional device features, such as fp64, but because of the above option we only end up with a single device image that contains both fp64 and non-fp64 code because of the runtime check.
Since there can only be one image, we can't use fp64 at all on non-fp64 hardware, so a runtime check won't work.
Split the test into a non-fp64 and fp64-only version.
The above is what we do for other tests that test double conditionally on non-fp64 hardware, such as invoke_simd_conv_double.cpp