[Driver] Fix FPGAEmulationMode naming confusion

[srividya-sundaram]

Fixes #4061

[srividya-sundaram]

Failures seem related to sycl::multi_ptr and is un-related to changes in this PR.
Other PRs are also failing with the same errors related to sycl::multi_ptr.

[mdtoguchi]

This looks like a good opportunity to update around

llvm/clang/lib/Driver/Driver.cpp

Line 6417 in 2fc89ac

SmallVector<std::pair<types::ID, bool>, 4> FPGAAOCTypes = {

to use the enum - what do you think?

[srividya-sundaram]

This looks like a good opportunity to update around

llvm/clang/lib/Driver/Driver.cpp

Line 6417 in 2fc89ac

SmallVector<std::pair<types::ID, bool>, 4> FPGAAOCTypes = {

to use the enum - what do you think?

Could you please elaborate?
IsFPGAEmulation is already invoking IsFPGAEmulationMode to get the enum value. Did you mean something else?

[mdtoguchi]

This looks like a good opportunity to update around

llvm/clang/lib/Driver/Driver.cpp

Line 6417 in 2fc89ac

SmallVector<std::pair<types::ID, bool>, 4> FPGAAOCTypes = {

to use the enum - what do you think?

Could you please elaborate? IsFPGAEmulation is already invoking IsFPGAEmulationMode to get the enum value. Did you mean something else?

In the array of pairs, you can see that the IsFPGAEmulation bool is just checking against the second value of the pair to see if the type is an emulation type or not. Instead of doing that, just do an IsFPGAHardware or IsFPGAEmulation kind of check. Just a suggestion though, wanted to see what your thoughts were.

[mdtoguchi]

LGTM - thanks

[srividya-sundaram]

@intel/llvm-gatekeepers Hi, this is ready for merge. Failures reported are un-related to changes in this PR.

[steffenlarsen]

@intel/llvm-gatekeepers Hi, this is ready for merge. Failures reported are un-related to changes in this PR.

@srividya-sundaram - Please resolve the merge conflict.