[SYCL] vec abi unification and trivially copyable #9492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm - am getting an internal error on Linux when it's trying to preprocess the builtins macros. But I can't reproduce this error locally. The CI is using GCC 11.3.0 , but that works for me. I also tested GCC 9.4 and Clang 17.0, both worked as well. Even tried a debug build using GCC 11.3.0, worked fine. |
…on errors. also remove old conjunction code for std::conjunction
cperkinsintel
commented
Jul 12, 2023
…E_ON_HOST__ is irrelevant. Removing.
romanovvlad
reviewed
Jul 28, 2023
|
Ping to reviewers, I believe I've addressed all the concerns, either here or in conversations offline. They are holding the ABI-breaking window open for this PR, so I'd like keep the process moving along. Let me know if you need anything else. |
rolandschulz
approved these changes
Aug 1, 2023
|
Post-commit found that the redirected call will cause a recursion as the double overload is defined later than the call to it. To avoid this #10652 moves said overload definition. |
dm-vodopyanov
pushed a commit
that referenced
this pull request
Aug 9, 2023
The recent sycl::vec changes (#9492) broke they unary operations. This PR fixes them and adds some testing to avoid that in the future.
cperkinsintel
added a commit
to cperkinsintel/llvm
that referenced
this pull request
Oct 17, 2023
This reverts commit 531aabf.
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
adapted from intel#6816 sycl::vec now uses std::array on host in all cases, but device access is via `ext_vector_type` so as to not lose performance. Alignment is set the same as the size to a maximum of 64 bytes, which aligns with an upcoming spec change proposal. In the cases where the size is greater than 64 we use std::array on the device. We no longer need to emit a pragma on Windows and we can use `alignas()` on all platforms.
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
The recent sycl::vec changes (intel#9492) broke they unary operations. This PR fixes them and adds some testing to avoid that in the future.
cperkinsintel
added a commit
to cperkinsintel/llvm
that referenced
this pull request
Oct 27, 2023
This reverts commit 531aabf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapted from #6816
sycl::vec now uses std::array on host in all cases, but device access is via
ext_vector_typeso as to not lose performance. Alignment is set the same as the size to a maximum of 64 bytes, which aligns with an upcoming spec change proposal. In the cases where the size is greater than 64 we use std::array on the device. We no longer need to emit a pragma on Windows and we can usealignas()on all platforms.