[SYCL] Print supported SG sizes in sycl-ls --verbose #9481
Conversation
And use that as dynamic features in our SYCL End-to-End tests framework.
|
I'm not sure if that really belongs to |
I definitely think it does! Supported sub-group sizes share some behavior with aspects and is a device-specific thing. Having an easy way to get it for a given device without having to write a custom program every time could be super-useful! |
|
This seems like a useful extension. Do we have any documentation for the "REQUIRE" syntax that we use in our e2e tests? It seems like that would be useful for people writing tests, otherwise they won't know about this new feature. |
I'm in the middle of changing the LIT infrastructure in a significant way and will work on updating the docs once everything is finalized and implemented (probably about a week or two from today). |
I agree. Users are already requesting this, and so we could even consider this the first step towards implementing #9104. |
| @@ -1,3 +1,4 @@ | |||
| // REQUIRES: sg-8 | |||
There was a problem hiding this comment.
This is great! I do wonder if we could maybe also add a way for the test-config to tell us what a (common?) supported sub-group size is, so we could for example pass that to the test (e.g. as a -D definition) so we don't have to guess at a sub-group size when writing tests like this.
Not directly related to this, but it's something to think about.
|
@intel/dpcpp-esimd-reviewers , can you take a look at the missing esimd_emulator's support for this? |
Addressed in #9612. |
And use that as dynamic features in our SYCL End-to-End tests framework.