Skip to content

[SYCL] Fix CTAD-related issue with std::lock_guard #8883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

dm-vodopyanov
Copy link
Contributor

This patch fixes post-commit failure introduced in #7468:

/Users/runner/work/llvm/llvm/src/sycl/source/detail/program_manager/program_manager.cpp:1324:9: error: 'lock_guard' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
        std::lock_guard HostPipesGuard(m_HostPipesMutex);
        ^

@dm-vodopyanov dm-vodopyanov requested a review from a team as a code owner March 30, 2023 15:21
@dm-vodopyanov dm-vodopyanov changed the title [SYCL] Fix CTAD-related issue with std::lock_guard on macOS [SYCL] Fix CTAD-related issue with std::lock_guard Mar 30, 2023
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws March 30, 2023 16:20 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov temporarily deployed to aws March 30, 2023 17:59 — with GitHub Actions Inactive
@steffenlarsen
Copy link
Contributor

Failed Tests (1):
SYCL :: AtomicRef/atomic_memory_order_acq_rel.cpp
Being disabled in #8885.

Failure in Jenkins precommit is an infrastructure problem and is unrelated.

@steffenlarsen steffenlarsen merged commit 33bf2a7 into intel:sycl Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants