-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][Doc] Update SYCL_INTEL_data_flow_pipes extension for FPGA host… #8789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2023
@rho180 , can you please take a look at this Spec? |
sycl/doc/extensions/supported/sycl_ext_intel_dataflow_pipes.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/supported/sycl_ext_intel_dataflow_pipes.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/supported/sycl_ext_intel_dataflow_pipes.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/supported/sycl_ext_intel_dataflow_pipes.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/supported/sycl_ext_intel_dataflow_pipes.asciidoc
Outdated
Show resolved
Hide resolved
rho180
reviewed
Mar 28, 2023
sycl/doc/extensions/supported/sycl_ext_intel_dataflow_pipes.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
gmlueck
reviewed
Mar 28, 2023
sycl/doc/extensions/supported/sycl_ext_intel_dataflow_pipes.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/supported/sycl_ext_intel_dataflow_pipes.asciidoc
Outdated
Show resolved
Hide resolved
steffenlarsen
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zibaiwan! LGTM!
@steffenlarsen , thanks for your review. The test passed for the doc change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #5838. Accompanying runtime change is #7468.
Add a memory order parameter to device-side read/write members and
default to sycl::memory_order::seq_cst. This parameter is in place but not being used at this moment, it's intended for the future work.
Add host pipe read/write members with additional sycl::queue parameter.