Skip to content

[SYCL][Doc] Update SYCL_INTEL_data_flow_pipes extension for FPGA host… #8789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 30, 2023

Conversation

zibaiwan
Copy link
Contributor

@zibaiwan zibaiwan commented Mar 27, 2023

A continuation of #5838. Accompanying runtime change is #7468.

Add a memory order parameter to device-side read/write members and
default to sycl::memory_order::seq_cst. This parameter is in place but not being used at this moment, it's intended for the future work.

Add host pipe read/write members with additional sycl::queue parameter.

@zibaiwan zibaiwan marked this pull request as ready for review March 27, 2023 20:37
@zibaiwan zibaiwan requested a review from a team as a code owner March 27, 2023 20:37
@zibaiwan zibaiwan marked this pull request as draft March 27, 2023 20:37
@zibaiwan zibaiwan marked this pull request as ready for review March 28, 2023 14:09
@zibaiwan
Copy link
Contributor Author

@rho180 , can you please take a look at this Spec?

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zibaiwan! LGTM!

@zibaiwan
Copy link
Contributor Author

@steffenlarsen , thanks for your review. The test passed for the doc change.

@bader bader requested review from gmlueck and rho180 March 29, 2023 22:07
@steffenlarsen steffenlarsen merged commit 6b2d66b into intel:sycl Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants