-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL-MLIR] Opaque pointer support Polygeist-to-LLVM #8767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL-MLIR] Opaque pointer support Polygeist-to-LLVM #8767
Conversation
I did not want to migrate all our components to opaque pointers in a single step, as the resulting PR would be huge. Instead, this is the first step, affecting only the Polygeist to LLVM lowering. As some of the patterns are shared with other lowerings and other tests/components still rely on this lowering to produce typed pointers, I had to introduce a "versioning". The existing patterns now have a "Old" suffix, and the patterns with the unmodified name have been changed to support opaque pointers. The The patterns (and functions) with the "Old" suffix as well as the option can be removed as soon as we complete the transition to opaque pointers. They are unmodified compared to Having the versioning and option also allow us to continue to produce typed pointers, in case other tools out-of-scope of this project (e.g., SPIR-V translator) still need to complete the transition. The LIT tests for the Polygeist to LLVM lowering already verify the correctness of the opaque pointer version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have the pointee type in all check lines with GEPOp
operations?
polygeist/lib/Dialect/Polygeist/Transforms/BareMemRefToLLVM.cpp
Outdated
Show resolved
Hide resolved
ce865e5
to
ee55e26
Compare
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
ee55e26
to
f7823e0
Compare
First step to add opaque pointer support for the SYCL-MLIR project: Make the lowering patterns in the Polygeist-to-LLVM lowering compatible with opaque pointers.
Partly resolves #8616.