Skip to content

[SYCL][ESIMD] BFN function implementation #8708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 24, 2023
Merged

Conversation

turinevgeny
Copy link
Contributor

@turinevgeny turinevgeny commented Mar 21, 2023

API follows a similar one offered by CM.
Example: d = esimd::bfn<~bfn_t::x & ~bfn_t::y & ~bfn_t::z>(s0, s1, s2);

API follows a similar one offered by CM.
Example: d = bfn<~bfn_x & ~bfn_y & ~bfn_z>(s0, s1, s2);
@turinevgeny turinevgeny requested a review from a team as a code owner March 21, 2023 06:08
@turinevgeny turinevgeny temporarily deployed to aws March 21, 2023 07:44 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws March 21, 2023 08:13 — with GitHub Actions Inactive
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm, but prolly should get a second review for correctness

@turinevgeny turinevgeny temporarily deployed to aws March 23, 2023 00:18 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws March 23, 2023 07:18 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws March 23, 2023 16:18 — with GitHub Actions Inactive
@v-klochkov
Copy link
Contributor

@vmustya - You asked to show you the changes for BFN before merge. If you want to review the changes - it is a good moment. Thank you.

@turinevgeny turinevgeny temporarily deployed to aws March 23, 2023 17:34 — with GitHub Actions Inactive
@turinevgeny turinevgeny temporarily deployed to aws March 23, 2023 21:04 — with GitHub Actions Inactive
@bader bader merged commit 25d0475 into intel:sycl Mar 24, 2023
@turinevgeny turinevgeny deleted the esimd_bfn branch March 28, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants