[SYCL] Implement two-run aspect propagation #8681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit splits aspect propagation into two runs:
1. First run propagates all aspects, except fp64. Warnings are still
issued for fp64 as if it was fully propagated, but the resulting
metadata will not reflect it. This run before optimizations.
2. Second run propagates all aspects, including fp64. This should not
have any effect on already propagated aspects. This run will not
issue warnings as any conflicts would have been reported by the
first pass.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
AlexeySachkov
approved these changes
Mar 21, 2023
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
elizabethandrews
approved these changes
Mar 21, 2023
smanna12
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit splits aspect propagation into two runs:
See the design document for more information.