-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL] Fix ICE when -g and -ffile-prefix-map flags are set #8459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fmacro-prefix-map is used when generating debug information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you describe what this change is doing in more detail in PR description?
Added check lines for the directory path in the LIT tests to make sure it's correct.
@bwyma Thanks for reviewing and checking the debug information. I have fixed the issue you raised about the directory path. Also added in the other LIT tests a check line for the directory to make sure it's correct (instead of using regular expression). Would you please check if this new patch fixes the issue? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with debug information that needs to be generated but I trust @bwyma's approval!
@intel/dpcpp-devops-reviewers I have been re-basing and re-testing this PR for a week. Can someone help with the latest fail please? Thanks. |
@apstasen , could you take a look please? We've seen similar issue with not getting AWS CUDA runner picked up in at least one another PR. |
I hope #8567 fixes this issue. |
The testing started 14h 14m 8s ago. Unlless I am mistaken this is still hanging? |
@zahiraam, you need to merge the fix to your |
@bader Your fix seems to have worked. Thanks. |
Set the source file name when footer is present and option fmacro-prefix-map is used when generating debug information.
This patch is to fix a crash in the compiler when generating debug information with the option -ffile-prefix-map.
Example:
$ pwd
/tmp/tmp.jocQk9WVa0
$
$ cat builtin.cpp
void a(__builtin_va_list);
using ::a;
$
$ clang -c -g -fsycl /tmp/tmp.jocQk9WVa0/builtin.cpp
$
$ clang -g -fsycl -ffile-prefix-map=/tmp/= /tmp/tmp.jocQk9WVa0/builtin.cpp
Expected must be checked before access or destruction.
Unchecked Expected contained error:
No such file or directoryPLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0. Program arguments:
…………………/tmp/tmp.jocQk9WVa0/builtin.cpp
https://github.com/intel/llvm/blob/sycl/clang/lib/CodeGen/CGDebugInfo.cpp#L397 is returning a error because the FileName is wrong.