Skip to content

[CI] Drop DPCPP_ENABLE_OPAQUE_POINTERS cmake flag #8286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 23, 2023
Merged

[CI] Drop DPCPP_ENABLE_OPAQUE_POINTERS cmake flag #8286

merged 6 commits into from
Mar 23, 2023

Conversation

bader
Copy link
Contributor

@bader bader commented Feb 10, 2023 •
edited
Loading

All tools are switched to opaque pointers already except those we use in compilation for offload targets.

@bader
[CI] Drop DPCPP_ENABLE_OPAQUE_POINTERS cmake flag
37a2e44 
All tools are switched to opaque pointers already except those we use in
compilation for SPIR-V.
@bader bader requested a review from jcranmer-intel February 10, 2023 01:15
@bader bader requested a review from a team as a code owner February 10, 2023 01:15
bader
bader commented Feb 10, 2023
View reviewed changes
@aelovikov-intel aelovikov-intel self-requested a review February 14, 2023 22:40
@bader bader marked this pull request as draft February 27, 2023 18:31
@bader bader temporarily deployed to aws March 3, 2023 04:09 — with GitHub Actions Inactive
@bader bader temporarily deployed to aws March 15, 2023 17:38 — with GitHub Actions Inactive
@bader bader temporarily deployed to aws March 15, 2023 22:06 — with GitHub Actions Inactive
@bader bader temporarily deployed to aws March 23, 2023 02:57 — with GitHub Actions Inactive
@bader bader temporarily deployed to aws March 23, 2023 03:40 — with GitHub Actions Inactive
@bader bader marked this pull request as ready for review March 23, 2023 03:53
@bader bader requested review from a team as code owners March 23, 2023 03:53
@bader bader requested a review from sergey-semenov March 23, 2023 03:53
jchlanda
jchlanda approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@jchlanda jchlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libclc/remangler LGTM

@bader
Copy link
Contributor Author

bader commented Mar 23, 2023

@intel/dpcpp-devops-reviewers, ping.

@bader bader merged commit 130466e into intel:sycl Mar 23, 2023
@bader bader deleted the enable-opaque-pointers branch March 23, 2023 23:02
whitneywhtsang added a commit to whitneywhtsang/llvm that referenced this pull request Mar 25, 2023
@whitneywhtsang
Revert "[CI] Drop DPCPP_ENABLE_OPAQUE_POINTERS cmake flag (intel#8286)"
eacd870 
This reverts commit 130466e.
@jle-quel jle-quel mentioned this pull request Mar 27, 2023
Closed
@sommerlukas sommerlukas mentioned this pull request Mar 28, 2023
Merged
sommerlukas added a commit to sommerlukas/llvm that referenced this pull request Aug 23, 2023
@sommerlukas
Revert "Revert "[CI] Drop DPCPP_ENABLE_OPAQUE_POINTERS cmake flag (in…
ded8acb 
…tel#8286)""

This reverts commit eacd870.

Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchlanda jchlanda jchlanda approved these changes

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@jcranmer-intel jcranmer-intel jcranmer-intel approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov sergey-semenov is a code owner automatically assigned from intel/llvm-reviewers-cuda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bader @jchlanda @AlexeySachkov @jcranmer-intel @aelovikov-intel