[SYCL] Throw exceptions while creating sub buffer #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"Throw exceptions while creating sub buffer" - it says that I can't create sub-buffer! |
romanovvlad
reviewed
Nov 12, 2019
KarachunIvan
force-pushed
the
private/ivankara/subbuffer_reinterpret_elements
branch
2 times, most recently
from
8e027c6 to
040307f
Compare
Sure, the commit title is a bit confusing. Changed. |
agozillon
reviewed
Nov 13, 2019
Throw `invalid_object_error` exception if memory region of constructed sub buffer specified by offset and sub buffer size doesn't represent contiguous region or if it exceeds parent bounds. Signed-off-by: Ivan Karachun <ivan.karachun@intel.com>
KarachunIvan
force-pushed
the
private/ivankara/subbuffer_reinterpret_elements
branch
from
040307f to
102ffdf
Compare
romanovvlad
approved these changes
Nov 13, 2019
KarachunIvan
deleted the
private/ivankara/subbuffer_reinterpret_elements
branch
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Nov 30, 2020
Spec: KhronosGroup/SPIRV-Registry#85 Signed-off-by: amochalo <anastasiya.mochalova@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw
invalid_object_errorexception if memory region ofconstructed sub buffer specified by offset and sub buffer size
doesn't represent contiguous region or if it exceeds parent bounds.
Signed-off-by: Ivan Karachun ivan.karachun@intel.com