Skip to content

[ESIMD] Fix errors caused by move of bfloat16 from experimental ns (#… #7981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

v-klochkov
Copy link
Contributor

…9143)

The error in LIT test esimd/intel_fp16_converts.cpp is caused by #6524 which

  • moved 'bfloat16' out of 'experimental' namespace
  • created a wrapper __devicelib_ConvertBF16ToFINTEL() which simply calls __spirv_ConvertBF16ToFINTEL()

The fix

  • creates a test for bfloat16 conversions.
  • allows __devicelib_ConvertBF16ToFINTEL() and __devicelib_ConvertFToBF16INTEL() for ESIMD context.

Signed-off-by: Vyacheslav N Klochkov vyacheslav.n.klochkov@intel.com

…ntel#9143)

The error in LIT test esimd/intel_fp16_converts.cpp is caused
by intel#6524 which
- moved 'bfloat16' out of 'experimental' namespace
- created a wrapper __devicelib_ConvertBF16ToFINTEL() which simply calls __spirv_ConvertBF16ToFINTEL()

The fix
- create a test for bfloat16 conversions.
- allows __devicelib_ConvertBF16ToFINTEL() and __devicelib_ConvertFToBF16INTEL() for ESIMD context.

Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
@v-klochkov v-klochkov requested review from a team as code owners January 11, 2023 08:01
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE changes LGTM.

Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE changes look good to me.

@v-klochkov v-klochkov temporarily deployed to aws January 12, 2023 01:10 — with GitHub Actions Inactive
@v-klochkov v-klochkov temporarily deployed to aws January 12, 2023 23:52 — with GitHub Actions Inactive
@v-klochkov v-klochkov temporarily deployed to aws January 13, 2023 04:02 — with GitHub Actions Inactive
@v-klochkov v-klochkov temporarily deployed to aws January 13, 2023 04:48 — with GitHub Actions Inactive
@v-klochkov v-klochkov merged commit 506f279 into intel:sycl Jan 13, 2023
@v-klochkov v-klochkov deleted the esimd_bloat16_filter branch January 13, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants