Skip to content

[SYCL][Clang][HIP] Disable macro __CUDA_ARCH__ for AMD hip-platform #7977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2023
Merged

[SYCL][Clang][HIP] Disable macro __CUDA_ARCH__ for AMD hip-platform #7977

merged 4 commits into from
Jan 13, 2023

Conversation

abagusetty
Copy link
Contributor

@abagusetty abagusetty commented Jan 11, 2023 •
edited
Loading

Fixes #7720

@abagusetty abagusetty requested a review from a team as a code owner January 11, 2023 00:24
@bader
Copy link
Contributor

bader commented Jan 11, 2023

"Fixes: Issue #7720" -> "Fixes #7720".

This will link PR with to an issue. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@bader bader changed the title [SYCL][Clang][HIP] disable macro __CUDA_ARCH__ for AMD hip-platform [SYCL][Clang][HIP] Disable macro __CUDA_ARCH__ for AMD hip-platform Jan 11, 2023
premanandrao
premanandrao reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test?

@abagusetty abagusetty temporarily deployed to aws January 12, 2023 08:09 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 12, 2023 15:04 — with GitHub Actions Inactive
@bader
Copy link
Contributor

bader commented Jan 13, 2023

@abagusetty, there was a bug in CI system, which caused a hang for tests on CUDA. To pull the fix for this problem, could you merge the head of the sycl branch to your hip-cuda-arch branch, please? Sorry for inconvenience.

@abagusetty
Copy link
Contributor Author

@abagusetty, there was a bug in CI system, which caused a hang for tests on CUDA. To pull the fix for this problem, could you merge the head of the sycl branch to your hip-cuda-arch branch, please? Sorry for inconvenience.

Sure, thanks for the pointer.

@abagusetty abagusetty temporarily deployed to aws January 13, 2023 03:46 — with GitHub Actions Inactive
@abagusetty abagusetty temporarily deployed to aws January 13, 2023 04:32 — with GitHub Actions Inactive
@bader bader merged commit 8a7cf2b into intel:sycl Jan 13, 2023
@abagusetty abagusetty deleted the hip-cuda-arch branch January 13, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premanandrao premanandrao premanandrao approved these changes

@elizabethandrews elizabethandrews elizabethandrews approved these changes

@smanna12 smanna12 smanna12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SYCL] [HIP] __CUDA_ARCH__ defined when compiling for HIP backend
5 participants
@abagusetty @bader @premanandrao @elizabethandrews @smanna12