-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Update bfloat16.cpp test to pass in no-assert mode #7602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Actually that doesn't work. It looks like asserts are not supported in sycl. Need some other solution. |
Test was modified at intel#6524 Change fixes post-commit issue in no-asserts mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough to fix post-commit failures. I'd expect @rdeodhar to follow-up post-commit if anything could be improved.
HIP failure in max_local has been reported in #7604. |
@steffenlarsen, do you have any idea why these appeared on HIP? I've seen it in a few other PRs as well but cannot easily connect to any recent change.
|
It looks like LIT is having trouble reading some exit code for one of the RUN lines. It is curious that it only happens for HIP, but the failure itself is not very informative. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good for now.
Test was modified at #6524
Change fixes post-commit issue in no-asserts mode