Skip to content

[SYCL] Update bfloat16.cpp test to pass in no-assert mode #7602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

pvchupin
Copy link
Contributor

@pvchupin pvchupin commented Dec 1, 2022

Test was modified at #6524

Change fixes post-commit issue in no-asserts mode

@pvchupin pvchupin marked this pull request as ready for review December 1, 2022 00:45
@pvchupin pvchupin requested a review from a team as a code owner December 1, 2022 00:45
@pvchupin
Copy link
Contributor Author

pvchupin commented Dec 1, 2022

Actually that doesn't work. It looks like asserts are not supported in sycl. Need some other solution.

@pvchupin pvchupin closed this Dec 1, 2022
@pvchupin pvchupin reopened this Dec 1, 2022
Test was modified at intel#6524

Change fixes post-commit issue in no-asserts mode
@pvchupin pvchupin changed the title [SYCL] Require asserts for bfloat16 test [SYCL] Update bfloat16.cpp test to pass in no-assert mode Dec 1, 2022
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough to fix post-commit failures. I'd expect @rdeodhar to follow-up post-commit if anything could be improved.

@steffenlarsen
Copy link
Contributor

HIP failure in max_local has been reported in #7604.

@steffenlarsen steffenlarsen merged commit 9ff6045 into intel:sycl Dec 1, 2022
@pvchupin pvchupin deleted the bfloat16 branch December 1, 2022 15:54
@pvchupin
Copy link
Contributor Author

pvchupin commented Dec 1, 2022

@steffenlarsen, do you have any idea why these appeared on HIP? I've seen it in a few other PRs as well but cannot easily connect to any recent change.

Unresolved Tests (5):
  SYCL :: Assert/assert_in_kernels.cpp
  SYCL :: Assert/assert_in_multiple_tus.cpp
  SYCL :: Assert/assert_in_multiple_tus_one_ndebug.cpp
  SYCL :: Assert/assert_in_one_kernel.cpp
  SYCL :: Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp

@steffenlarsen
Copy link
Contributor

@steffenlarsen, do you have any idea why these appeared on HIP? I've seen it in a few other PRs as well but cannot easily connect to any recent change.

Unresolved Tests (5):
  SYCL :: Assert/assert_in_kernels.cpp
  SYCL :: Assert/assert_in_multiple_tus.cpp
  SYCL :: Assert/assert_in_multiple_tus_one_ndebug.cpp
  SYCL :: Assert/assert_in_one_kernel.cpp
  SYCL :: Assert/assert_in_simultaneously_multiple_tus_one_ndebug.cpp

It looks like LIT is having trouble reading some exit code for one of the RUN lines. It is curious that it only happens for HIP, but the failure itself is not very informative.

Copy link
Contributor

@rdeodhar rdeodhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants