[SPIR-V] Cherry-pick of "Add SPIR-V 1.4 checks"

[MrSidims]

One of the patches missing in intel/llvm

Signed-off-by: Sidorov, Dmitry dmitry.sidorov@intel.com

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@c5b3c8e3283b

Second attempt

[MrSidims]

/verify

[MrSidims]

/summary:run

[MrSidims]

trying to trigger windows testing

[MrSidims]

/verify with intel/llvm-test-suite#1414

[MrSidims]

/verify with intel/llvm-test-suite#1414

[MrSidims]

/start Windows testing

[MrSidims]

/start Windows testing

[MrSidims]

/start Windows testing

[MrSidims]

/verify with intel/llvm-test-suite#1477

[MrSidims]

/testwin

[MrSidims]

/verify with intel/llvm-test-suite#1479

[MrSidims]

select_device.cpp is unrelated test failure, reported internally
level_zero_batch_barrier.cpp is unrelated test failure, that is being fixed in intel/llvm-test-suite#1481

SubGroupMask/Basic.cpp on windows to investigate

[asudarsa]

LGTM overall. Just some nitpicks on some changes. But I suppose I am also not looking at the full commit here. Ok to merge. Thanks. And yes, sorry for delay in review.

[bader]

Please, resolve merge conflicts.

[MrSidims]

/summary:run

[MrSidims]

Other issues are found - seems like CPU and GPU SPIR-V consumers restrict max to 1.2, but I'm not sure why. Also for some reasons it happens only for KernelFusion tests (only they use SPIR-V 1.4 functionality?). Need to have extra investigation. Converted to draft for now.

[MrSidims]

It seems like that before going to the device's driver, the code is being put to the translator one more (or two more?) time(s). And when it's done, --spirv-max-version is set to 1.2, while the module can already contain SPIR-V 1.4 features. @sommerlukas @Naghasan is my understanding correct? If so, can we change --spirv-max-version to 1.4 in whatever tool, that fusion uses? TBH I can't find in intel/llvm, where it's being set with an exception of clang driver, where it's set to 1.4 (unless we compile to HIP, where SPIR-V is 1.1).

[sommerlukas]

It seems like that before going to the device's driver, the code is being but to the translator one more (or two more?) time(s). And when it's done, --spirv-max-version is set to 1.2, while the module can already contain SPIR-V 1.4 features. @sommerlukas @Naghasan is my understanding correct? If so, can we change --spirv-max-version to 1.4 in whatever tool, that fusion uses? TBH I can't find in intel/llvm, where it's being set with an exception of clang driver, where it's set to 1.4 (unless we compile to HIP, where SPIR-V is 1.1).

Hi @MrSidims,
the SPIR-V version for translation to/from SPIR-V for fusion is set here:
https://github.com/intel/llvm/blob/sycl/sycl-fusion/jit-compiler/lib/translation/SPIRVLLVMTranslation.cpp#L63

We initially chose 1.2 as the maximum value, as this is a safe default for OpenCL 2.2 devices.

You can remove setting the maximum version there, so kernel fusion would use the tool default.

[MrSidims]

@sommerlukas thanks! I've created #8358 . One of the biggest reasons to move to 1.4 is that partial unrolling started to be supported only in this version, and we would lack performance in some workloads if we wouldn't switch. Also our compiler implementation heavily relies on UserSemantic decoration, which is also added in 1.4. So while OpenCL 2.2 reasoning is legit, unfortunately we can't stick to it :( .

[sommerlukas]

@MrSidims: Thanks for the explanation! From our side, 1.2 was only the initial choice, it should be fine to switch to 1.4.

[MrSidims]

/summary:run

[MrSidims]

Alexey's requested change was to merge sycl branch into this one
With the tests passing I believe the PR is good to go @intel/llvm-gatekeepers