-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Add intel::kernel_args_restrict attribute #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vladimirlaz
merged 5 commits into
intel:sycl
from
asavonic:private/asavonic/kernel_args_restrict
Oct 22, 2019
Merged
[SYCL] Add intel::kernel_args_restrict attribute #744
vladimirlaz
merged 5 commits into
intel:sycl
from
asavonic:private/asavonic/kernel_args_restrict
Oct 22, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When applied to a device function that is invoked as a device kernel, the attribute is a hint to the compiler that no pointer argument to the kernel which is defined through an accessor (not USM), will alias any other pointer kernel argument that was defined through an accessor. This effect is equivalent to annotating restrict on all kernel pointer arguments in an OpenCL or SPIR-V kernel. Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
Fznamznon
reviewed
Oct 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, some minor comments.
Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
FunctionLike also applies to function pointers, which is probably not what we want. Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
Fznamznon
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vladimirlaz
pushed a commit
that referenced
this pull request
Sep 29, 2020
debug info of work-item builtins are lost in both llvm IR -> spirv and spirv -> llvm IR translations. See #744
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
- This PR is for clearing failures observed while merging intel/llvm PR enabling esimd_emulator support by default (intel#5058) - Another PR should be created for actively loading and testing 'esimd_emulator' backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applied to a device function that is invoked as a device kernel,
the attribute is a hint to the compiler that no pointer argument to
the kernel which is defined through an accessor (not USM), will alias
any other pointer kernel argument that was defined through an
accessor. This effect is equivalent to annotating restrict on all
kernel pointer arguments in an OpenCL or SPIR-V kernel.
Signed-off-by: Andrew Savonichev andrew.savonichev@intel.com