Skip to content

[SYCL] Add intel::kernel_args_restrict attribute #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

asavonic
Copy link
Contributor

When applied to a device function that is invoked as a device kernel,
the attribute is a hint to the compiler that no pointer argument to
the kernel which is defined through an accessor (not USM), will alias
any other pointer kernel argument that was defined through an
accessor. This effect is equivalent to annotating restrict on all
kernel pointer arguments in an OpenCL or SPIR-V kernel.

Signed-off-by: Andrew Savonichev andrew.savonichev@intel.com

When applied to a device function that is invoked as a device kernel,
the attribute is a hint to the compiler that no pointer argument to
the kernel which is defined through an accessor (not USM), will alias
any other pointer kernel argument that was defined through an
accessor. This effect is equivalent to annotating restrict on all
kernel pointer arguments in an OpenCL or SPIR-V kernel.

Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
@asavonic asavonic requested a review from Fznamznon October 21, 2019 10:01
Copy link
Contributor

@Fznamznon Fznamznon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, some minor comments.

Andrew Savonichev added 3 commits October 21, 2019 15:03
Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
FunctionLike also applies to function pointers, which is probably not
what we want.

Signed-off-by: Andrew Savonichev <andrew.savonichev@intel.com>
Copy link
Contributor

@Fznamznon Fznamznon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimirlaz vladimirlaz merged commit 722006c into intel:sycl Oct 22, 2019
vladimirlaz pushed a commit that referenced this pull request Sep 29, 2020
debug info of work-item builtins are lost in both llvm IR -> spirv and
spirv -> llvm IR translations. See #744
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Feb 23, 2023
- This PR is for clearing failures observed while merging intel/llvm
PR enabling esimd_emulator support by default
(intel#5058)

- Another PR should be created for actively loading and testing
'esimd_emulator' backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants