Skip to content

[SYCL][DOC] Update pass to propagate sycl_declared #7415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

KornevNikita
Copy link
Contributor

No description provided.

@KornevNikita KornevNikita requested a review from a team as a code owner November 16, 2022 12:06
@KornevNikita
Copy link
Contributor Author

As discussed with @gmlueck this bullet should be added, so RT is able to throw an exception when the kernel calls some function marked with sycl_decalred_aspects (even if this aspect is unused) and the device doesn't support the required aspect.

Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@steffenlarsen steffenlarsen merged commit ed61939 into intel:sycl Nov 16, 2022
KornevNikita added a commit to KornevNikita/llvm that referenced this pull request Nov 16, 2022
To make RT be able to throw an exception if device doesn't support the
feature pass should also propagate sycl_declared aspects by merging it
with sycl_used_aspects.
Spec: intel#7415
AlexeySachkov pushed a commit that referenced this pull request Nov 17, 2022
To make RT be able to throw an exception if device doesn't support the
feature pass should also propagate sycl_declared aspects by merging it
with sycl_used_aspects.
Design: #7415
@KornevNikita KornevNikita deleted the update-design branch December 9, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants