[SYCL] Collect sycl_declared_aspects metadata #7359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In scope of optional kernel features implementation we should also collect sycl_declared_aspects metadata to right "aspects" property spec: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/OptionalDeviceFeatures.md#create-the-sycldevice-requirements-property-set
|
@intel/sycl-language-enabling-triage take a look please |
Comment on lines
+17
to
+22
|
|
||
| $kernel1 = comdat any | ||
|
|
||
| $kernel2 = comdat any | ||
|
|
||
| $kernel3 = comdat any |
There was a problem hiding this comment.
Suggested change
| $kernel1 = comdat any | |
| $kernel2 = comdat any | |
| $kernel3 = comdat any |
| constexpr std::pair<const char *, const char *> ReqdMDs[] = { | ||
| {"sycl_used_aspects", "aspects"}, {"sycl_fixed_targets", "fixed_target"}}; | ||
| for (const Function &F : M) { | ||
| FindAspectsByMDName(F, "sycl_used_aspects"); |
There was a problem hiding this comment.
sycl_used_aspects are propagated up to kernels and therefore, we could optimize this loop by limiting amount of functions we are looking for. Since sycl_declared_aspects is not yet being propagated, I suggest that for now we leave a comment about this potential optimization
|
Closing this PR because this work should be done in SYCLPropagateAspectsUsagePass. |
|
Another decision: #7419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scope of optional kernel features implementation we should also collect sycl_declared_aspects metadata to create right "aspects" property
spec: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/OptionalDeviceFeatures.md#create-the-sycldevice-requirements-property-set