Skip to content

[SYCL] Rectified precision issue with the float->half conversion. #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2019
Merged

[SYCL] Rectified precision issue with the float->half conversion. #714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/source/half_type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ static uint16_t float2Half(const float &Val) {
uint16_t Ret = 0;
Ret |= Sign;
Ret |= Exp16 << 10;
Ret |= Frac16;
Ret += Frac16;// Add the carry bit from operation Frac16 += 1;

return Ret;
}
Expand Down
2 changes: 2 additions & 0 deletions sycl/test/basic_tests/half_type.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,8 @@ int main() {
assert(bitwise_comparison_fp16(0.0, 0));
// -0
assert(bitwise_comparison_fp16(-0.0, 32768));
// 1.9999f
assert(bitwise_comparison_fp16(1.9999f, 0x4000));
// nan
assert(bitwise_comparison_fp16(0.0 / 0.0, 32256));
assert(bitwise_comparison_fp16(-0.0 / 0.0, 32256));
Expand Down