[SYCL] Fix retaining of kernels in old kernel interop #7034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intel#6980 caused some unexpected regressions on OpenCL for SYCL 1.2.1 kernel interop constructors. This commit reintroduces the call to retaining the OpenCL kernel only for the old constructor. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
cperkinsintel
approved these changes
Oct 12, 2022
Contributor
cperkinsintel
left a comment
cperkinsintel
left a comment
There was a problem hiding this comment.
LGTM, but @smaslov-intel should probably weigh in. Does this potentially double the retain being performed at backend.cpp as noted https://github.com/intel/llvm/pull/6980/files ?
Contributor
Author
|
smaslov-intel
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6980 caused some unexpected regressions on OpenCL for SYCL 1.2.1 kernel interop constructors. This commit reintroduces the call to retaining the OpenCL kernel only for the old constructor.