[SYCL][ESIMD] Fix an issue causing a build break when building ESIMD on Windows platform #6789
Conversation
| @@ -16,6 +16,8 @@ | |||
| #include <sycl/ext/intel/esimd/detail/defines_elementary.hpp> | |||
| #include <sycl/ext/intel/esimd/detail/memory_intrin.hpp> | |||
|
|
|||
| using uint = unsigned int; | |||
There was a problem hiding this comment.
I don't think spoiling global namespace like this is good. Is there a standard header where it is defined?
There was a problem hiding this comment.
+1. I think this needs to be fixed
There was a problem hiding this comment.
Oh, this is already fixed.
There was a problem hiding this comment.
Looks Ok/good to me.
Just a comment: using 'uint32_t' may be more explicit than 'unsigned'.
'uint32_t' is already used in that detail/memory_intrin.hpp now.
@kbobrovs - FYI and maybe additional comments.
| { | ||
| sycl::queue q; | ||
| sycl::device dev = q.get_device(); | ||
| sycl::context ctx = q.get_context(); |
I think using |
No description provided.