[SYCL] Fix debug info generation when integration footer is present #6774

zahiraam · 2022-09-13T20:12:40Z

This patch is to fix two known issues with debugging caused by integration footer presence, without redesigning the integration footer approach.
One issue is the missing checksum for the main file on Windows. This causes the breakpoints not being hit.
The other issue being that the host compilation's DICompileUnit points to the temporary
file created instead of the original source file. So file names and checksums are different for host and compilation.

The changes made to fix the issues are:

Driver passes an absolute path to an original source file through -main-file-name if integration footer is enabled.
Driver passes a full path to the original source file through -full-main-file-name.
Clang CodeGen uses the file specified through -main-file-name and full-main-file-name to calculate checksums and file names for the main file.

Joint work with @AlexeySachkov

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

zahiraam · 2022-09-14T20:45:30Z

/verify with intel/llvm-test-suite#1264

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

clang/include/clang/Driver/Options.td

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

stevemerr · 2022-09-22T12:46:48Z

FYI, I did some debug info testing with the current change set. It does resolve the originally reported issue with breakpoints on Windows and also removes any references to the temporary file. I did not encounter any negative impact from the change set.

zahiraam · 2022-09-22T13:13:17Z

FYI, I did some debug info testing with the current change set. It does resolve the originally reported issue with breakpoints on Windows and also removes any references to the temporary file. I did not encounter any negative impact from the change set.

@stevemerr thanks for taking the time!

zahiraam · 2022-09-22T13:14:41Z

Not really sure what the issue is with CUDA testing. It's failing after 1mn with this error:
Starting download for sycl_linux_default
Error: Unable to find an artifact with the name: sycl_linux_default

zahiraam · 2022-09-22T20:43:55Z

@intel/dpcpp-cfe-reviewers Can you please review the patch? Thanks.

clang/test/CodeGenSYCL/debug-info-file-checksum.cpp

clang/test/Driver/sycl-int-footer.cpp

elizabethandrews

I'm not familiar with this at all. @premanandrao can you please take a look?

clang/lib/CodeGen/CGDebugInfo.cpp

clang/test/ClangScanDeps/modules-context-hash-ignore-macros.c

clang/lib/CodeGen/CGDebugInfo.cpp

clang/test/CodeGenSYCL/debug-info-checksum-temp-name.cpp

clang/test/Driver/sycl-int-footer.cpp

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

premanandrao · 2022-09-26T20:53:27Z

clang/lib/Driver/ToolChains/Clang.cpp


+  if (IsSYCL || Args.hasArg(options::OPT_fsycl_footer_path_EQ)) {


Is the IsSYCL check needed here?

Not sure. Does Args.hasArg(options::OPT_fsycl_footer_path_EQ) == true implies IsSYCL?

I talked to Mike Rice and it looks like OpenMP doesn't use footers. So I can presumably just check for the option and not test for IsSycl.

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

elizabethandrews

LGTM

zahiraam · 2022-09-27T17:57:27Z

Just heard from @stevemerr that the additional specific debugger testing passed with this patch. Thanks Steve!

Fznamznon · 2022-09-28T12:14:15Z

Could you please take a look at failing test?

sycl-intelfpga-return-check and debug-info-srcspos-kernel.cpp. Both are using the -fsycl-is-device and -fsycl-device-only repectively. When these options are used isSYCL returns false. So it's needed in the condition, in order to set the option "full-main-file-name". Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

zahiraam · 2022-09-28T12:53:46Z

Could you please take a look at failing test?
Removing the IsSYCL part of the condition leads to 2 fails: sycl-intelfpga-return-check and debug-info-srcspos-kernel.cpp. Both are using the -fsycl-is-device and -fsycl-device-only repectively. When these options are used isSYCL returns false. So isSYCL is needed in the condition, in order to set the option "full-main-file-name".

zahiraam · 2022-09-28T18:15:22Z

@premanandrao , @Fznamznon at your convenience can you please review this? Thanks.

premanandrao · 2022-09-29T18:23:06Z

Could you please take a look at failing test?
Removing the IsSYCL part of the condition leads to 2 fails: sycl-intelfpga-return-check and debug-info-srcspos-kernel.cpp. Both are using the -fsycl-is-device and -fsycl-device-only repectively. When these options are used isSYCL returns false. So isSYCL is needed in the condition, in order to set the option "full-main-file-name".

Thanks for the explanation.

zahiraam · 2022-09-29T18:29:45Z

@intel/llvm-gatekeepers PR is ready for review and merge. Thanks.

pvchupin · 2022-09-29T21:36:36Z

@zahiraam, please follow up on post-commit issue on Windows: https://github.com/intel/llvm/actions/runs/3153782586

Failed Tests (1):
  Clang :: CodeGenSYCL/debug-info-file-checksum.cpp

zahiraam · 2022-09-30T14:47:10Z

@zahiraam, please follow up on post-commit issue on Windows: https://github.com/intel/llvm/actions/runs/3153782586
Failed Tests (1):
  Clang :: CodeGenSYCL/debug-info-file-checksum.cpp

@pvchupin I tried to reproduce the issue locally. Although the test is failing, I don't get the same fail. The one I get is the same than the one we get for CodeGen/debug-info-file-checksum.c on Windows; the checksums are different on windows and Linux because of some environmental line ending issue. That's a known issue and there is some on-going fix for it in community.
I don't see in the actions link above that there were some special windows configurations to reproduce that fail?

pvchupin · 2022-09-30T17:56:28Z

@zahiraam, I'm getting the same crash locally. I'm using MSVC2022 if it helps.
Would you like me to revert the patch?

pvchupin · 2022-09-30T18:58:47Z

@zahiraam, here is the backtrace from debug version:

Expected<T> must be checked before access or destruction.
Unchecked Expected<T> contained error:
invalid argumentPLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.      Program arguments: d:\\iusers\\pvchupin\\pvchupin-llvm\\build\\bin\\clang.exe -cc1 -internal-isystem d:\\iusers\\pvchupin\\pvchupin-llvm\\build\\lib\\clang\\16.0.0\\include -nostdsysteminc -triple x86_64-unknown-linux-gnu -fsycl-is-host -include D:\\iusers\\pvchupin\\pvchupin-llvm\\build\\tools\\clang\\test\\CodeGenSYCL\\Output\\debug-info-file-checksum.cpp.tmp.header.h -dependency-filter D:\\iusers\\pvchupin\\pvchupin-llvm\\build\\tools\\clang\\test\\CodeGenSYCL\\Output\\debug-info-file-checksum.cpp.tmp.header.h -main-file-name D:\\iusers\\pvchupin\\pvchupin-llvm\\clang\\test\\CodeGenSYCL/Inputs/checksum.cpp -fsycl-use-main-file-name -full-main-file-name D:\\iusers\\pvchupin\\pvchupin-llvm\\clang\\test\\CodeGenSYCL/Inputs/checksum.cpp -gcodeview -debug-info-kind=limited -emit-llvm -O0 -o - D:\\iusers\\pvchupin\\pvchupin-llvm\\build\\tools\\clang\\test\\CodeGenSYCL\\Output\\debug-info-file-checksum.cpp.tmp.checksum.cpp
1.      <eof> parser at end of file
2.      D:iuserspvchupinpvchupin-llvmclang      estCodeGenSYCL/Inputs/checksum.cpp:1:5: LLVM IR generation of declaration 'main'
3.      D:iuserspvchupinpvchupin-llvmclang      estCodeGenSYCL/Inputs/checksum.cpp:1:5: Generating code for declaration 'main'
Exception Code: 0x80000003
 #0 0x00007ff709281c9c HandleAbort D:\iusers\pvchupin\pvchupin-llvm\llvm\lib\Support\Windows\Signals.inc:414:0
 #1 0x00007ffa6f848e05 (C:\WINDOWS\SYSTEM32\ucrtbased.dll+0xa8e05)
 #2 0x00007ffa6f84ab29 (C:\WINDOWS\SYSTEM32\ucrtbased.dll+0xaab29)
 #3 0x00007ff709a1dd35 llvm::Expected<class clang::FileEntryRef>::fatalUncheckedExpected(void) const D:\iusers\pvchupin\pvchupin-llvm\llvm\include\llvm\Support\Error.h:708:0
 #4 0x00007ff709a1cfd8 llvm::Expected<class clang::FileEntryRef>::assertIsChecked(void) const D:\iusers\pvchupin\pvchupin-llvm\llvm\include\llvm\Support\Error.h:716:0
 #5 0x00007ff709a1a794 llvm::Expected<class clang::FileEntryRef>::~Expected<class clang::FileEntryRef>(void) D:\iusers\pvchupin\pvchupin-llvm\llvm\include\llvm\Support\Error.h:552:0
 #6 0x00007ff709b962b7 ComputeValidFileID(class clang::SourceManager &, class llvm::StringRef) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CGDebugInfo.cpp:389:0
 #7 0x00007ff709b8e3e0 clang::CodeGen::CGDebugInfo::getOrCreateFile(class clang::SourceLocation) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CGDebugInfo.cpp:429:0
 #8 0x00007ff709b813cc clang::CodeGen::CGDebugInfo::emitFunctionStart(class clang::GlobalDecl, class clang::SourceLocation, class clang::SourceLocation, class clang::QualType, class llvm::Function *, bool) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CGDebugInfo.cpp:4088:0
 #9 0x00007ff70a1f57b6 clang::CodeGen::CodeGenFunction::StartFunction(class clang::GlobalDecl, class clang::QualType, class llvm::Function *, class clang::CodeGen::CGFunctionInfo const &, class clang::CodeGen::FunctionArgList const &, class clang::SourceLocation, class clang::SourceLocation) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenFunction.cpp:1226:0
#10 0x00007ff70a1ecc56 clang::CodeGen::CodeGenFunction::GenerateCode(class clang::GlobalDecl, class llvm::Function *, class clang::CodeGen::CGFunctionInfo const &) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenFunction.cpp:1615:0
#11 0x00007ff709d6b887 clang::CodeGen::CodeGenModule::EmitGlobalFunctionDefinition(class clang::GlobalDecl, class llvm::GlobalValue *) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenModule.cpp:5814:0
#12 0x00007ff709d6b526 clang::CodeGen::CodeGenModule::EmitGlobalDefinition(class clang::GlobalDecl, class llvm::GlobalValue *) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenModule.cpp:3906:0
#13 0x00007ff709d61c27 clang::CodeGen::CodeGenModule::EmitGlobal(class clang::GlobalDecl) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenModule.cpp:3647:0
#14 0x00007ff709d594dc clang::CodeGen::CodeGenModule::EmitTopLevelDecl(class clang::Decl *) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenModule.cpp:6676:0
#15 0x00007ff712cf40d3 `anonymous namespace'::CodeGeneratorImpl::HandleTopLevelDecl D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\ModuleBuilder.cpp:189:0
#16 0x00007ff712ced0f2 clang::BackendConsumer::HandleTopLevelDecl(class clang::DeclGroupRef) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenAction.cpp:236:0
#17 0x00007ff70e9728d4 clang::ParseAST(class clang::Sema &, bool, bool) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\Parse\ParseAST.cpp:166:0
#18 0x00007ff70aeb7aca clang::ASTFrontendAction::ExecuteAction(void) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\Frontend\FrontendAction.cpp:1154:0
#19 0x00007ff712cdfd7d clang::CodeGenAction::ExecuteAction(void) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenAction.cpp:1191:0
#20 0x00007ff70aeb73be clang::FrontendAction::Execute(void) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\Frontend\FrontendAction.cpp:1049:0
#21 0x00007ff70ae2fc4c clang::CompilerInstance::ExecuteAction(class clang::FrontendAction &) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\Frontend\CompilerInstance.cpp:1042:0
#22 0x00007ff70b103c60 clang::ExecuteCompilerInvocation(class clang::CompilerInstance *) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\FrontendTool\ExecuteCompilerInvocation.cpp:266:0
#23 0x00007ff706603154 cc1_main(class llvm::ArrayRef<char const *>, char const *, void *) D:\iusers\pvchupin\pvchupin-llvm\clang\tools\driver\cc1_main.cpp:250:0
#24 0x00007ff7065eaf79 ExecuteCC1Tool D:\iusers\pvchupin\pvchupin-llvm\clang\tools\driver\driver.cpp:317:0
#25 0x00007ff7065eb9e4 clang_main(int, char **) D:\iusers\pvchupin\pvchupin-llvm\clang\tools\driver\driver.cpp:388:0
#26 0x00007ff70663006c main D:\iusers\pvchupin\pvchupin-llvm\build\tools\clang\tools\driver\clang-driver.cpp:11:0
#27 0x00007ff71230d079 invoke_main d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:79:0
#28 0x00007ff71230cf1e __scrt_common_main_seh d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288:0
#29 0x00007ff71230cdde __scrt_common_main d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331:0
#30 0x00007ff71230d10e mainCRTStartup d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17:0
#31 0x00007ffaa6247e94 (C:\WINDOWS\System32\KERNEL32.DLL+0x17e94)
#32 0x00007ffaa8a07ad1 (C:\WINDOWS\SYSTEM32\ntdll.dll+0x67ad1)

zahiraam · 2022-09-30T20:20:28Z

@zahiraam, here is the backtrace from debug version:

Expected<T> must be checked before access or destruction.
Unchecked Expected<T> contained error:
invalid argumentPLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.      Program arguments: d:\\iusers\\pvchupin\\pvchupin-llvm\\build\\bin\\clang.exe -cc1 -internal-isystem d:\\iusers\\pvchupin\\pvchupin-llvm\\build\\lib\\clang\\16.0.0\\include -nostdsysteminc -triple x86_64-unknown-linux-gnu -fsycl-is-host -include D:\\iusers\\pvchupin\\pvchupin-llvm\\build\\tools\\clang\\test\\CodeGenSYCL\\Output\\debug-info-file-checksum.cpp.tmp.header.h -dependency-filter D:\\iusers\\pvchupin\\pvchupin-llvm\\build\\tools\\clang\\test\\CodeGenSYCL\\Output\\debug-info-file-checksum.cpp.tmp.header.h -main-file-name D:\\iusers\\pvchupin\\pvchupin-llvm\\clang\\test\\CodeGenSYCL/Inputs/checksum.cpp -fsycl-use-main-file-name -full-main-file-name D:\\iusers\\pvchupin\\pvchupin-llvm\\clang\\test\\CodeGenSYCL/Inputs/checksum.cpp -gcodeview -debug-info-kind=limited -emit-llvm -O0 -o - D:\\iusers\\pvchupin\\pvchupin-llvm\\build\\tools\\clang\\test\\CodeGenSYCL\\Output\\debug-info-file-checksum.cpp.tmp.checksum.cpp
1.      <eof> parser at end of file
2.      D:iuserspvchupinpvchupin-llvmclang      estCodeGenSYCL/Inputs/checksum.cpp:1:5: LLVM IR generation of declaration 'main'
3.      D:iuserspvchupinpvchupin-llvmclang      estCodeGenSYCL/Inputs/checksum.cpp:1:5: Generating code for declaration 'main'
Exception Code: 0x80000003
 #0 0x00007ff709281c9c HandleAbort D:\iusers\pvchupin\pvchupin-llvm\llvm\lib\Support\Windows\Signals.inc:414:0
 #1 0x00007ffa6f848e05 (C:\WINDOWS\SYSTEM32\ucrtbased.dll+0xa8e05)
 #2 0x00007ffa6f84ab29 (C:\WINDOWS\SYSTEM32\ucrtbased.dll+0xaab29)
 #3 0x00007ff709a1dd35 llvm::Expected<class clang::FileEntryRef>::fatalUncheckedExpected(void) const D:\iusers\pvchupin\pvchupin-llvm\llvm\include\llvm\Support\Error.h:708:0
 #4 0x00007ff709a1cfd8 llvm::Expected<class clang::FileEntryRef>::assertIsChecked(void) const D:\iusers\pvchupin\pvchupin-llvm\llvm\include\llvm\Support\Error.h:716:0
 #5 0x00007ff709a1a794 llvm::Expected<class clang::FileEntryRef>::~Expected<class clang::FileEntryRef>(void) D:\iusers\pvchupin\pvchupin-llvm\llvm\include\llvm\Support\Error.h:552:0
 #6 0x00007ff709b962b7 ComputeValidFileID(class clang::SourceManager &, class llvm::StringRef) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CGDebugInfo.cpp:389:0
 #7 0x00007ff709b8e3e0 clang::CodeGen::CGDebugInfo::getOrCreateFile(class clang::SourceLocation) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CGDebugInfo.cpp:429:0
 #8 0x00007ff709b813cc clang::CodeGen::CGDebugInfo::emitFunctionStart(class clang::GlobalDecl, class clang::SourceLocation, class clang::SourceLocation, class clang::QualType, class llvm::Function *, bool) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CGDebugInfo.cpp:4088:0
 #9 0x00007ff70a1f57b6 clang::CodeGen::CodeGenFunction::StartFunction(class clang::GlobalDecl, class clang::QualType, class llvm::Function *, class clang::CodeGen::CGFunctionInfo const &, class clang::CodeGen::FunctionArgList const &, class clang::SourceLocation, class clang::SourceLocation) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenFunction.cpp:1226:0
#10 0x00007ff70a1ecc56 clang::CodeGen::CodeGenFunction::GenerateCode(class clang::GlobalDecl, class llvm::Function *, class clang::CodeGen::CGFunctionInfo const &) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenFunction.cpp:1615:0
#11 0x00007ff709d6b887 clang::CodeGen::CodeGenModule::EmitGlobalFunctionDefinition(class clang::GlobalDecl, class llvm::GlobalValue *) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenModule.cpp:5814:0
#12 0x00007ff709d6b526 clang::CodeGen::CodeGenModule::EmitGlobalDefinition(class clang::GlobalDecl, class llvm::GlobalValue *) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenModule.cpp:3906:0
#13 0x00007ff709d61c27 clang::CodeGen::CodeGenModule::EmitGlobal(class clang::GlobalDecl) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenModule.cpp:3647:0
#14 0x00007ff709d594dc clang::CodeGen::CodeGenModule::EmitTopLevelDecl(class clang::Decl *) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenModule.cpp:6676:0
#15 0x00007ff712cf40d3 `anonymous namespace'::CodeGeneratorImpl::HandleTopLevelDecl D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\ModuleBuilder.cpp:189:0
#16 0x00007ff712ced0f2 clang::BackendConsumer::HandleTopLevelDecl(class clang::DeclGroupRef) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenAction.cpp:236:0
#17 0x00007ff70e9728d4 clang::ParseAST(class clang::Sema &, bool, bool) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\Parse\ParseAST.cpp:166:0
#18 0x00007ff70aeb7aca clang::ASTFrontendAction::ExecuteAction(void) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\Frontend\FrontendAction.cpp:1154:0
#19 0x00007ff712cdfd7d clang::CodeGenAction::ExecuteAction(void) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\CodeGen\CodeGenAction.cpp:1191:0
#20 0x00007ff70aeb73be clang::FrontendAction::Execute(void) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\Frontend\FrontendAction.cpp:1049:0
#21 0x00007ff70ae2fc4c clang::CompilerInstance::ExecuteAction(class clang::FrontendAction &) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\Frontend\CompilerInstance.cpp:1042:0
#22 0x00007ff70b103c60 clang::ExecuteCompilerInvocation(class clang::CompilerInstance *) D:\iusers\pvchupin\pvchupin-llvm\clang\lib\FrontendTool\ExecuteCompilerInvocation.cpp:266:0
#23 0x00007ff706603154 cc1_main(class llvm::ArrayRef<char const *>, char const *, void *) D:\iusers\pvchupin\pvchupin-llvm\clang\tools\driver\cc1_main.cpp:250:0
#24 0x00007ff7065eaf79 ExecuteCC1Tool D:\iusers\pvchupin\pvchupin-llvm\clang\tools\driver\driver.cpp:317:0
#25 0x00007ff7065eb9e4 clang_main(int, char **) D:\iusers\pvchupin\pvchupin-llvm\clang\tools\driver\driver.cpp:388:0
#26 0x00007ff70663006c main D:\iusers\pvchupin\pvchupin-llvm\build\tools\clang\tools\driver\clang-driver.cpp:11:0
#27 0x00007ff71230d079 invoke_main d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:79:0
#28 0x00007ff71230cf1e __scrt_common_main_seh d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288:0
#29 0x00007ff71230cdde __scrt_common_main d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331:0
#30 0x00007ff71230d10e mainCRTStartup d:\a01\_work\20\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17:0
#31 0x00007ffaa6247e94 (C:\WINDOWS\System32\KERNEL32.DLL+0x17e94)
#32 0x00007ffaa8a07ad1 (C:\WINDOWS\SYSTEM32\ntdll.dll+0x67ad1)

Yes I think I understand the issue. The problem is coming from the "append-file" command in the LIT test. The appended file in Linux has this shape:
#line 1 "/export/iusers/zahiraam/IntelLlvm/llvm/clang/test/CodeGenSYCL/Inputs/checksum.cpp"
int main() {
int x = 0;
return x + 1;
}
#include "/export/iusers/zahiraam/IntelLlvm/llvm/build/tools/clang/test/CodeGenSYCL/Output/debug-info-file-checksum.cpp.tmp.footer.h"
We can see that in the first line there is use of forward "/".

On Windows this is the shape of the appended file:
#line 1 "D:\IUSERS\zahiraam\sycl-bp\llvm\clang\test\CodeGenSYCL\Inputs\checksum.cpp"
int main() {
int x = 0;
return x + 1;
}
#include "D:\IUSERS\zahiraam\sycl-bp\llvm\build\tools\clang\test\CodeGenSYCL\Output\debug-info-file-checksum.cpp.tmp.footer.h"

It's using the backward "".

The call here https://github.com/intel/llvm/blob/sycl/clang/lib/CodeGen/CGDebugInfo.cpp#L404 is returning for Linux the correct filename and for Windows it's returning something like this: "D:IUSERSzahiraamsycl-bpllvmclang\testCodeGenSYCLInputschecksum.cpp" . The crash happens because this file is bogus and ExpectedFileRef here https://github.com/intel/llvm/blob/sycl/clang/lib/CodeGen/CGDebugInfo.cpp#L385 returns an error.

The string filenames are computed here: https://github.com/intel/llvm/blob/sycl/clang/lib/Lex/PPDirectives.cpp#L1434
So this is definitely an issue related to escape characters on Windows.
I tried creating an artificial "tmp" file in the Inputs folder instead of creating one using the append-file command but that doesn't really show the issue we are trying to prove , which is that checksum for host and compile files are identical.
So I think the LIT test should stay as is but may the right course here is to find and fix the bug in the literal string parser.
Your thoughts?

pvchupin · 2022-09-30T20:26:09Z

@zahiraam, sounds good to me. Should I revert this change as a whole to give you more time for analysis? Or you have a workaround? Or should we disable the test if the rest of the compiler is not impacted?
Basically need some patch soon to return post-commit to green.

zahiraam · 2022-09-30T21:51:01Z

@zahiraam, sounds good to me. Should I revert this change as a whole to give you more time for analysis? Or you have a workaround? Or should we disable the test if the rest of the compiler is not impacted? Basically need some patch soon to return post-commit to green.

@pvchupin To fix the literal string parser will take some more analysis and time. I want to try a fix in CGDebugInfo.cpp and see if that doesn't break other tests. But I will do that Monday. If you want post-commit to be green today, you can disable the LIT test and I will work on a fix one way or the other. Thanks.

We have changed the code in #6774, but we did wrong resolution recently.

zahiraam added 2 commits September 13, 2022 13:09

[SYCL] Fix debug info generation when integration footer is present

aa090b2

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

Fix LIT test modules-context-hash-ignore-macros.c.

e595273

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

zahiraam assigned stevemerr Sep 15, 2022

zahiraam added 2 commits September 20, 2022 11:24

Fix setting BP on windows.

8ab8763

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

Moved checksum.cpp to Inputs folder.

4506b33

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

zahiraam marked this pull request as ready for review September 21, 2022 15:00

zahiraam requested review from a team as code owners September 21, 2022 15:00

mdtoguchi reviewed Sep 21, 2022

View reviewed changes

clang/include/clang/Driver/Options.td Outdated Show resolved Hide resolved

Respond to review comment.

cfc331d

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

mdtoguchi approved these changes Sep 22, 2022

View reviewed changes

smanna12 reviewed Sep 22, 2022

View reviewed changes

clang/test/CodeGenSYCL/debug-info-file-checksum.cpp Show resolved Hide resolved

smanna12 reviewed Sep 22, 2022

View reviewed changes

clang/test/Driver/sycl-int-footer.cpp Outdated Show resolved Hide resolved

elizabethandrews reviewed Sep 22, 2022

View reviewed changes

clang/lib/CodeGen/CGDebugInfo.cpp Outdated Show resolved Hide resolved

clang/lib/CodeGen/CGDebugInfo.cpp Show resolved Hide resolved

clang/test/ClangScanDeps/modules-context-hash-ignore-macros.c Outdated Show resolved Hide resolved

Fznamznon reviewed Sep 23, 2022

View reviewed changes

clang/lib/CodeGen/CGDebugInfo.cpp Outdated Show resolved Hide resolved

clang/lib/CodeGen/CGDebugInfo.cpp Outdated Show resolved Hide resolved

premanandrao reviewed Sep 23, 2022

View reviewed changes

clang/test/CodeGenSYCL/debug-info-checksum-temp-name.cpp Outdated Show resolved Hide resolved

clang/test/Driver/sycl-int-footer.cpp Outdated Show resolved Hide resolved

Respond to review comments.

316f47c

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

zahiraam requested review from Fznamznon, premanandrao, smanna12 and elizabethandrews September 23, 2022 18:29

Enable the option -full-main-filename for the sycl path only.

85f22a6

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

premanandrao reviewed Sep 26, 2022

View reviewed changes

Remove redundant IsSYCL condition.

2cc31bb

Signed-off-by: Zahira Ammarguellat <zahira.ammarguellat@intel.com>

zahiraam requested a review from premanandrao September 27, 2022 17:51

elizabethandrews approved these changes Sep 27, 2022

View reviewed changes

smanna12 approved these changes Sep 27, 2022

View reviewed changes

Fznamznon approved these changes Sep 28, 2022

View reviewed changes

premanandrao approved these changes Sep 29, 2022

View reviewed changes

pvchupin merged commit 83febf9 into intel:sycl Sep 29, 2022

Fznamznon mentioned this pull request Oct 4, 2022

[SYCL] Disable the LIT test 'debug-info-file-checksum.cpp' for Windows. #6938

Merged

XinWang10 mentioned this pull request Dec 14, 2023

Fix wrong resolution about CGDebugInfo.cpp #12170

Merged

XinWang10 added a commit that referenced this pull request Dec 14, 2023

Fix wrong resolution about CGDebugInfo.cpp (#12170)

459904b

We have changed the code in #6774, but we did wrong resolution recently.


		if (IsSYCL \|\| Args.hasArg(options::OPT_fsycl_footer_path_EQ)) {

[SYCL] Fix debug info generation when integration footer is present #6774

[SYCL] Fix debug info generation when integration footer is present #6774

Uh oh!

Conversation

zahiraam commented Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zahiraam commented Sep 14, 2022

Uh oh!

Uh oh!

stevemerr commented Sep 22, 2022

Uh oh!

zahiraam commented Sep 22, 2022

Uh oh!

zahiraam commented Sep 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zahiraam commented Sep 22, 2022

Uh oh!

Uh oh!

Uh oh!

elizabethandrews left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

premanandrao Sep 26, 2022

Choose a reason for hiding this comment

Uh oh!

zahiraam Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

zahiraam Sep 27, 2022

Choose a reason for hiding this comment

Uh oh!

elizabethandrews left a comment

Choose a reason for hiding this comment

Uh oh!

zahiraam commented Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fznamznon commented Sep 28, 2022

Uh oh!

zahiraam commented Sep 28, 2022

Uh oh!

zahiraam commented Sep 28, 2022

Uh oh!

premanandrao commented Sep 29, 2022

Uh oh!

zahiraam commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pvchupin commented Sep 29, 2022

Uh oh!

zahiraam commented Sep 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pvchupin commented Sep 30, 2022

Uh oh!

pvchupin commented Sep 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zahiraam commented Sep 30, 2022

Uh oh!

pvchupin commented Sep 30, 2022

Uh oh!

zahiraam commented Sep 30, 2022

Uh oh!

Uh oh!

zahiraam commented Sep 13, 2022 •

edited

Loading

zahiraam commented Sep 22, 2022 •

edited

Loading

zahiraam commented Sep 27, 2022 •

edited

Loading

zahiraam commented Sep 29, 2022 •

edited

Loading

zahiraam commented Sep 30, 2022 •

edited

Loading

pvchupin commented Sep 30, 2022 •

edited

Loading