Skip to content

[SYCL] Add MAJOR_VERSION to the name of the sycl library on Win #6745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2022
Merged

[SYCL] Add MAJOR_VERSION to the name of the sycl library on Win #6745

merged 2 commits into from
Sep 14, 2022

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel requested review from a team as code owners September 8, 2022 23:07
@aelovikov-intel
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1237

mdtoguchi
mdtoguchi reviewed Sep 8, 2022
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes are pretty straightforward and prevent any unexpected usage of an old library at runtime. Just feels... odd.

romanovvlad
romanovvlad previously approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdtoguchi
mdtoguchi previously approved these changes Sep 9, 2022
View reviewed changes
@aelovikov-intel
Copy link
Contributor Author

2013 SYCL :: Plugin/level_zero_events_caching.cpp

Known issue - being addressed at intel/llvm-test-suite#1138

@aelovikov-intel
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1237

@aelovikov-intel
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1237

@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Sep 14, 2022 •
edited
Loading

The failure in ESMID Emu task looks unrelated and I believe I saw another notification (for another PR) saying it's being worked on already. Update: being fixed in intel/llvm-test-suite#1264 .

@intel/llvm-gatekeepers , please merge this together with intel/llvm-test-suite#1237

@againull againull merged commit c8427d6 into intel:sycl Sep 14, 2022
@mdtoguchi mdtoguchi mentioned this pull request Oct 5, 2022
Merged
@aelovikov-intel aelovikov-intel deleted the win-ver2 branch November 8, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanovvlad romanovvlad romanovvlad approved these changes

@mdtoguchi mdtoguchi mdtoguchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aelovikov-intel @romanovvlad @mdtoguchi @againull