-
Notifications
You must be signed in to change notification settings - Fork 769
[Matrix][SYCL] Add bfloat16 support for joint_matrix #6113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i reopened #5566 in this PR. |
Are we able to run post-checkin when the patch is under review? |
Not as far as I know. I believe the most frequent failure difference between the pre- and post-commit testing is werror. You should be able to turn it on locally and that should hopefully help detect it before post-commit. |
i tried "python configure.py --werror" but can't work. however, i copied the command from compile_commands.json and add"-Werror=unused-parameter", then i can reproduce the issue in post-commit. |
there is another thing in https://github.com/intel/llvm/runs/6310070794?check_suite_focus=true. https://godbolt.org/z/rzzoWrPrd is a small reproducer, Hi, @mdtoguchi , did the clang do the right thing? or did gcc&icc do the right thing? In summary, the original intent is to use "-Wno-unused-parameter " when compiling opencl.cpp but that option is not effective due to the existence of Wextra. |
It looks like |
i can't manually move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping? @steffenlarsen |
@yubingex007-a11y - Just to make sure I follow the intention of this patch. This is a reopening of #5566 as it was reverted in #6108. Are there any changes in this relative to #5566 or were all the issues handled in #6111? |
all the issues were handled in #6111, and this PR carries the same patch in #5566. |
@steffenlarsen could you help us merge it as well? |
No description provided.