Skip to content

[Matrix][SYCL] Add bfloat16 support for joint_matrix #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 9, 2022

Conversation

yubingex007-a11y
Copy link
Contributor

No description provided.

@yubingex007-a11y
Copy link
Contributor Author

i reopened #5566 in this PR.

@yubingex007-a11y
Copy link
Contributor Author

Are we able to run post-checkin when the patch is under review?

@steffenlarsen
Copy link
Contributor

Are we able to run post-checkin when the patch is under review?

Not as far as I know. I believe the most frequent failure difference between the pre- and post-commit testing is werror. You should be able to turn it on locally and that should hopefully help detect it before post-commit.

@yubingex007-a11y
Copy link
Contributor Author

yubingex007-a11y commented May 6, 2022

Are we able to run post-checkin when the patch is under review?

Not as far as I know. I believe the most frequent failure difference between the pre- and post-commit testing is werror. You should be able to turn it on locally and that should hopefully help detect it before post-commit.

i tried "python configure.py --werror" but can't work. however, i copied the command from compile_commands.json and add"-Werror=unused-parameter", then i can reproduce the issue in post-commit.
Do you have the command of configure.py for post-ci?

@yubingex007-a11y
Copy link
Contributor Author

yubingex007-a11y commented May 6, 2022

there is another thing in https://github.com/intel/llvm/runs/6310070794?check_suite_focus=true.
we can find that "-Wno-unused-parameter " is used in compiling opencl.cpp but still "unused-parameter" warning is reported as error(maybe it is because -Wextra enable -Wunused-parameter)
my local environment is using gcc to build sycl, so it didn't reproduce this issue

https://godbolt.org/z/rzzoWrPrd is a small reproducer, Hi, @mdtoguchi , did the clang do the right thing? or did gcc&icc do the right thing?

In summary, the original intent is to use "-Wno-unused-parameter " when compiling opencl.cpp but that option is not effective due to the existence of Wextra.

@yubingex007-a11y yubingex007-a11y requested a review from mdtoguchi May 6, 2022 13:48
@mdtoguchi
Copy link
Contributor

It looks like -Wextra is turning on -Wunused-parameter. Can you move -Wno-unused-parameter after -Wextra?

@yubingex007-a11y
Copy link
Contributor Author

It looks like -Wextra is turning on -Wunused-parameter. Can you move -Wno-unused-parameter after -Wextra?

i can't manually move -Wno-unused-parameter after -Wextra since the command is generated by ninja
besides, if -Wno-unused-parameter after -Wextra, -Wno-unused-parameter can work.

Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yubingex007-a11y
Copy link
Contributor Author

ping? @steffenlarsen

@steffenlarsen
Copy link
Contributor

@yubingex007-a11y - Just to make sure I follow the intention of this patch. This is a reopening of #5566 as it was reverted in #6108. Are there any changes in this relative to #5566 or were all the issues handled in #6111?

@yubingex007-a11y
Copy link
Contributor Author

@yubingex007-a11y - Just to make sure I follow the intention of this patch. This is a reopening of #5566 as it was reverted in #6108. Are there any changes in this relative to #5566 or were all the issues handled in #6111?

all the issues were handled in #6111, and this PR carries the same patch in #5566.

@yubingex007-a11y
Copy link
Contributor Author

@steffenlarsen could you help us merge it as well?

@steffenlarsen steffenlarsen merged commit 6ac62ab into intel:sycl May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants