Skip to content

[SYCL] Implement bf16 conversions on host device #5954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 24, 2022

Conversation

MrSidims
Copy link
Contributor

@MrSidims MrSidims commented Apr 3, 2022

They are implemented in a way of RNE conversion.

Signed-off-by: Dmitry Sidorov dmitry.sidorov@intel.com

They are implemented in a way of RNE conversion.

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims MrSidims requested a review from a team as a code owner April 3, 2022 18:58
@MrSidims MrSidims requested a review from vladimirlaz April 3, 2022 18:58
MrSidims added 3 commits April 3, 2022 22:02
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims MrSidims force-pushed the private/MrSidims/bf16_host branch from 9bdb770 to 8055dd1 Compare April 5, 2022 11:33
vladimirlaz
vladimirlaz previously approved these changes Apr 5, 2022
vladimirlaz
vladimirlaz previously approved these changes Apr 5, 2022
@MrSidims MrSidims requested review from dkhaldi and hdelan August 22, 2022 17:20
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
dkhaldi
dkhaldi previously approved these changes Aug 22, 2022
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@MrSidims
Copy link
Contributor Author

@hdelan @steffenlarsen could you please take a look?

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdelan
Copy link
Contributor

hdelan commented Aug 24, 2022

LGTM

@steffenlarsen steffenlarsen merged commit 2a383f1 into intel:sycl Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants