-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Implement bf16 conversions on host device #5954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
steffenlarsen
merged 12 commits into
intel:sycl
from
MrSidims:private/MrSidims/bf16_host
Aug 24, 2022
Merged
[SYCL] Implement bf16 conversions on host device #5954
steffenlarsen
merged 12 commits into
intel:sycl
from
MrSidims:private/MrSidims/bf16_host
Aug 24, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are implemented in a way of RNE conversion. Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
9bdb770
to
8055dd1
Compare
vladimirlaz
previously approved these changes
Apr 5, 2022
MrSidims
commented
Apr 5, 2022
vladimirlaz
previously approved these changes
Apr 5, 2022
Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
3a51dfe
to
1c4cccc
Compare
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
dkhaldi
reviewed
Apr 29, 2022
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
dkhaldi
previously approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
@hdelan @steffenlarsen could you please take a look? |
steffenlarsen
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM |
hdelan
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are implemented in a way of RNE conversion.
Signed-off-by: Dmitry Sidorov dmitry.sidorov@intel.com