Skip to content

Annotated refactorization after ABI constraint relaxed #5929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Annotated refactorization after ABI constraint relaxed #5929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sycl/include/CL/sycl/detail/pi.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,7 @@ class DeviceBinaryImage {
const PropertyRange getSpecConstantsDefaultValues() const {
// We can't have this variable as a class member, since it would break
// the ABI backwards compatibility.
// TODO: Refractor as class member after ABI constraint relaxed.
DeviceBinaryImage::PropertyRange SpecConstDefaultValuesMap;
SpecConstDefaultValuesMap.init(
Bin, __SYCL_PI_PROPERTY_SET_SPEC_CONST_DEFAULT_VALUES_MAP);
Expand All @@ -364,6 +365,7 @@ class DeviceBinaryImage {
const PropertyRange getAssertUsed() const {
// We can't have this variable as a class member, since it would break
// the ABI backwards compatibility.
// TODO: Refractor as class member after ABI constraint relaxed.
PropertyRange AssertUsed;
AssertUsed.init(Bin, __SYCL_PI_PROPERTY_SET_SYCL_ASSERT_USED);
return AssertUsed;
Expand All @@ -372,13 +374,15 @@ class DeviceBinaryImage {
const PropertyRange getExportedSymbols() const {
// We can't have this variable as a class member, since it would break
// the ABI backwards compatibility.
// TODO: Refractor as class member after ABI constraint relaxed.
DeviceBinaryImage::PropertyRange ExportedSymbols;
ExportedSymbols.init(Bin, __SYCL_PI_PROPERTY_SET_SYCL_EXPORTED_SYMBOLS);
return ExportedSymbols;
}
const PropertyRange getDeviceGlobals() const {
// We can't have this variable as a class member, since it would break
// the ABI backwards compatibility.
// TODO: Refractor as class member after ABI constraint relaxed.
DeviceBinaryImage::PropertyRange DeviceGlobals;
DeviceGlobals.init(Bin, __SYCL_PI_PROPERTY_SET_SYCL_DEVICE_GLOBALS);
return DeviceGlobals;
Expand Down