-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][Docs] Add new rule for naming C++ identifiers in SYCL project #5843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…headers and source files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for confusion. I was talking about the text you add to this document.
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@romanovvlad, @s-kanaev, please, share your thoughts on this.
Co-authored-by: Romanov Vlad <vlad.romanov@intel.com>
@s-kanaev, could you take a look, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds a new rule of naming C++ identifiers in
llvm/sycl
files. It aims to exclude possibility to fail SYCL app compilation by defining macros before includingCL/sycl.hpp
.