Skip to content

[SYCL][Docs] Add new rule for naming C++ identifiers in SYCL project #5843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 23, 2022

Conversation

HabKaffee
Copy link
Contributor

@HabKaffee HabKaffee commented Mar 21, 2022

This adds a new rule of naming C++ identifiers in llvm/sycl files. It aims to exclude possibility to fail SYCL app compilation by defining macros before including CL/sycl.hpp.

@HabKaffee HabKaffee requested a review from a team as a code owner March 21, 2022 08:42
@HabKaffee HabKaffee requested a review from bader March 21, 2022 10:05
@HabKaffee HabKaffee requested a review from bader March 22, 2022 09:19
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for confusion. I was talking about the text you add to this document.

Co-authored-by: Alexey Bader <alexey.bader@intel.com>
bader
bader previously approved these changes Mar 22, 2022
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romanovvlad, @s-kanaev, please, share your thoughts on this.

@bader bader changed the title [SYCL][Docs] Implementation of new rule of naming variables in SYCL header and source files [SYCL][Docs] Add new rule for naming C++ identifiers in SYCL project Mar 22, 2022
Co-authored-by: Romanov Vlad <vlad.romanov@intel.com>
@HabKaffee HabKaffee requested a review from bader March 22, 2022 22:02
@bader bader requested a review from romanovvlad March 23, 2022 08:17
@bader
Copy link
Contributor

bader commented Mar 23, 2022

@s-kanaev, could you take a look, please?

Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 1445528 into intel:sycl Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants