Skip to content

[SYCL] Remove unnecessary template parameter #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2021

Conversation

alexbatashev
Copy link
Contributor

@alexbatashev alexbatashev commented Dec 11, 2021

Replacing unnecessary KernelName parameter with a bool value that is actually used in HostKernel class reduces the number of instantiated templates and may improve host-side frontend time by ~9%.

@alexbatashev alexbatashev changed the title Remove unnecessary template [SYCL] Remove unnecessary template parameter Dec 12, 2021
@alexbatashev alexbatashev marked this pull request as ready for review December 12, 2021 07:32
@alexbatashev alexbatashev requested a review from a team as a code owner December 12, 2021 07:32
Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.

@bader bader merged commit cabb43f into intel:sycl Dec 13, 2021
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Dec 14, 2021
* sycl:
  [CI] Refactor workflow files (intel#5134)
  [CI] Enable HIP and CUDA plugins in GitHub Actions builds (intel#5087)
  [SYCL] Implement queue flushing (intel#5052)
  [SYCL] Allow library mismatch for libdevice host object on Win32 (intel#5048)
  [SYCL] Remove unnecessary template parameter (intel#5127)
  [CI] Use clang-format from nightly builds (intel#5126)
psalz added a commit to KhronosGroup/SYCL-CTS that referenced this pull request Dec 27, 2021
This includes two changes that should improve CTS compilation times
(intel/llvm#5127, intel/llvm#5178).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants